-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/tls: Config.GetConfigForClient is not sufficient for Listen #29139
Labels
Milestone
Comments
/cc @FiloSottile |
bcmills
added
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
FeatureRequest
labels
Dec 19, 2018
4 tasks
Yep, see also #18377. Will fix. |
FiloSottile
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
FeatureRequest
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Oct 1, 2019
Change https://golang.org/cl/205059 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
What version of Go are you using (
go version
)?What did you do?
Assume that I have a valid
tls.Config
(withCertificates
set), saved in the variableconf
.Then I can start listening on a new connection by running
Now I want to build a more sophisticated
tls.Config
, which in the simplest case takes the following formNow
returns
tls: neither Certificates nor GetCertificate set in Config
.What did you expect to see?
tls.Listen
should accept atls.Config
that hasGetConfigForClient
set, even ifCertificates
andGetCertificate
is not set.It should use the
tls.Config
returned by that callback, and close the connection with an error in case the returnedtls.Config
isnil
or doesn't have any certificate configured, depending on the SNI.What did you see instead?
tls.Listen
didn't accept thetls.Config
and returned an error.The text was updated successfully, but these errors were encountered: