Skip to content

proposal: new vet check complaining about string(int) and string(rune) #32758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
griesemer opened this issue Jun 24, 2019 · 4 comments
Closed

proposal: new vet check complaining about string(int) and string(rune) #32758

griesemer opened this issue Jun 24, 2019 · 4 comments
Labels
FrozenDueToAge Proposal v2 An incompatible library change
Milestone
Proposal

Comments

@griesemer
Copy link
Contributor

Because we cannot remove string(int)/string(rune) conversions (#3939) in a backwards-compatible way, start with disallowing these conversions in vet. This paves the path for the future, backwards-incompatible change #3939.
@griesemer griesemer added the v2 An incompatible library change label Jun 24, 2019
@gopherbot gopherbot added this to the Proposal milestone Jun 24, 2019
@ianlancetaylor
Copy link
Contributor

Same as #32749?

@griesemer
Copy link
Contributor Author

This may be a duplicate, but not of #32749.

@ianlancetaylor
Copy link
Contributor

Sorry, I meant #32479.

@griesemer
Copy link
Contributor Author

Yes, indeed (for some reason I didn't find it when I was looking for it.)
Closing as duplicate of #32479.

@golang golang locked and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal v2 An incompatible library change
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
3 participants
@ianlancetaylor @griesemer @gopherbot