x/tools/gopls: error checking package #34298
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
Tools
|
Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here. |
|
I think this is a duplicate of #34270. |
|
@fhs The stack trace is little different |
|
There seems to be a change that has fixed that https://go-review.googlesource.com/c/tools/+/195518 |
|
Can you confirm that you saw this error when working in code that had a space in the filepaths? If so, we can so we can deduplicate the issue to #34270. |
|
@stamblerre the path of the file was |
|
Oh ok, so then this seems to be a separate error. If you sync to master and install |
|
@stamblerre So I've updated to go 1.13 and synced I guess we can close this one here then. |
|
We can leave this open since you're still encountering issues. What is the output of |
stamblerre
changed the title
|
it prints the log below and then it hangs (that's the expected behaviour?) |
|
Hanging is definitely not the expected behavior. Do you mind sharing the actual command that you ran? Was the filepath |
that's the command I ran from the monorepo that we have at my company. After 30s I get OTOH when I run this from any other place e.g. home directory I get: |
|
I think you ran it from the correct directory in your previous comment--you have to run it from the root of the module, otherwise |
|
Correct, the first invocation was from the root of the module. The log that I've attached (actually both) are printed almost immediately (let's say it takes a second) and then it hungs for the remainder of 30s. I've tried sending sending a |
|
And if you open your editor at the module root, |
|
It works, although sometimes it has problems (nothing specific - the problem in the issue description was one of them) |
|
Hm, ok, my guess is that the error in the case of the command timing out is an issue with the But if you are seeing issue with |
|
I agree the original issue is resolved. I'll open a new open in case of any further problems |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
0240832f5c3d9ddcdcd51c66edbf8cd889a54108is the tip as of now ofgolang.org/x/tools/internalWhat operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
Use vscode-go version 0.11.5-beta.5 with vs code with gopls version
0240832f5c3d9ddcdcd51c66edbf8cd889a54108version v0.1.5-cmd.gopls, built in $GOPATH modeWhat did you expect to see?
No error, it seems that
phis not checked fornilhere https://github.com/golang/tools/blob/master/internal/lsp/source/util.go#L126I can submit a patch with that check which returns
nil, nil, errors.Errorf("ph is nil")or similar if that's the solution.What did you see instead?
The text was updated successfully, but these errors were encountered: