Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: #48949

Closed
halturin opened this issue Oct 13, 2021 · 6 comments
Closed

x/pkgsite: #48949

halturin opened this issue Oct 13, 2021 · 6 comments

Comments

@halturin
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/ergo-services/ergo

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36

Screenshot

image

What did you do?

just visit the link above

What did you expect to see?

Correct version. The latest tag is v.2.0.0

What did you see instead?

Version: v1.2.7-0...-83c5934

@gopherbot gopherbot added this to the Unreleased milestone Oct 13, 2021
@seankhliao
Copy link
Member

The module hasn't declared the correct module name (/v2 suffix) in its go.mod

@ALTree
Copy link
Member

ALTree commented Oct 13, 2021

Reading: https://go.dev/blog/v2-go-modules.

By definition, a new major version of a package is not backwards compatible with the previous version. This means a new major version of a module must have a different module path than the previous version.

@halturin
Copy link
Author

@ALTree thanks for the link. It explains well, but it worst solution that could be made, IMHO.

@ALTree
Copy link
Member

ALTree commented Oct 13, 2021

It's unpleasant indeed. Making it unpleasant to break backward-compatibility was one of the design goals:

Semantic import versioning is more work for authors of packages. They can't just decide to issue v2, walk away from v1, and leave users like Ugo to deal with the fallout. But authors who do that are hurting their users. It seems to me a good thing if the system makes it harder to hurt users and instead naturally steers authors toward behaviors that don't hurt users.

From the end of this, also linked in the blog post above.

@halturin
Copy link
Author

I believe, any bad solutions/decisions have enough reasons/explanations why they were made.

It would be much better to have it as an option, but not to force use this way. that's the only making me crazy )

@halturin
Copy link
Author

at least it shouldn't be a "must have" for the godoc.

@golang golang locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants