x/tools/go/internal/gccgoimporter: TestInstallationImporter failures with "bad magic number" on aix-ppc64

[bcmills]

greplogs --dashboard -md -l -e 'FAIL: TestInstallationImporter'

2021-11-07T04:57:22-0c60b7c-9e6ad46/aix-ppc64
2021-11-07T04:56:11-0c60b7c-85493d5/aix-ppc64
2021-11-06T19:41:15-0c60b7c-61d789d/aix-ppc64
2021-11-06T16:43:43-0c60b7c-3544082/aix-ppc64
2021-11-06T13:10:06-0c60b7c-4f083c7/aix-ppc64
2021-11-06T10:24:44-0c60b7c-f19e400/aix-ppc64
2021-11-06T00:29:44-0c60b7c-b74f2ef/aix-ppc64
2021-11-06T00:08:44-0c60b7c-f58c78a/aix-ppc64
2021-11-06T00:08:44-0c60b7c-23991f5/aix-ppc64
2021-11-06T00:08:44-0c60b7c-09e8de7/aix-ppc64
2021-11-06T00:08:25-ddcef59-f58c78a/aix-ppc64
2021-11-06T00:08:25-ddcef59-23991f5/aix-ppc64
2021-11-06T00:08:25-ddcef59-09e8de7/aix-ppc64
2021-11-05T23:32:57-b8b8e7f-f58c78a/aix-ppc64
2021-11-05T23:32:57-b8b8e7f-23991f5/aix-ppc64
2021-11-05T23:32:57-b8b8e7f-09e8de7/aix-ppc64
2021-11-05T22:57:08-4ab7496-09e8de7/aix-ppc64
2021-11-05T22:30:17-4ab7496-b07c41d/aix-ppc64
2021-11-05T22:03:24-4ab7496-035963c/aix-ppc64
2021-11-05T21:34:10-4ab7496-bb53fd7/aix-ppc64
2021-11-05T20:59:43-4ab7496-dbd3cf8/aix-ppc64
2021-11-05T20:06:27-4ab7496-7be227c/aix-ppc64
2021-11-05T19:14:22-4ab7496-fa16efb/aix-ppc64
2021-11-05T19:01:13-4ab7496-93bab8a/aix-ppc64
2021-11-05T18:05:53-4ab7496-f58c78a/aix-ppc64
2021-11-05T18:05:53-4ab7496-23991f5/aix-ppc64
2021-11-05T17:08:36-1c6f3cc-23991f5/aix-ppc64

[bcmills]

Ah, it's probably actually much longer than that: x/tools was disabled on aix-ppc64 for a long time because of a cmd/buildlet bug affecting that builder (#31567).

[bcmills]

@thanm, @ianlancetaylor: any idea what might be going wrong here?

[thanm]

I think the problem may be here:

https://go.googlesource.com/tools/+/ddcef59bac37cb1c01484cb6bbe7c246349ec0e8/go/internal/gccgoimporter/importer.go#110

Looks to me as though gccgoimporter is assuming ELF (which is not the case on AIX).

[thanm]

Given that we don't have a debug/xcoff package, perhaps it would make sense to skip the gccgo "installation" test on AIX? I can send a CL for that if needed.

[bcmills]

Yeah, adding a skip makes sense to me. Maybe add a TODO(#29038) to re-enable it?

(#29038)

[thanm]

I'll take a look. I think there may be some other changes in the main repo that need to be ported over to the x/tools version.

[thanm]

FYI @Helflym

[thanm]

Sent https://go-review.googlesource.com/c/tools/+/362248, along with a couple more CLs to port over main repo changes to x/tools.

[thanm]

Looks like I missed a testpoint (x/tools builder is still having issues on aix). Sent another CL to fix: https://go-review.googlesource.com/c/tools/+/362434.

[Helflym]

I'll try to add XCOFF support for that once I'll have time. It doesn't seem really different from main repo.
Meanwhile, skipping these tests looks good to me.

[thanm]

Closing this out since the aix buildre is green now for x/tools.