You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #47916 does not document the String method for types.TypeList (added in https://go.dev/cl/346552 to aid with debugging). Furthermore the otherwise symmetric TypeParamList type does not have a String method.
These two list types should be symmetric. Since types.TypeList.String was not covered by the proposal, probably we should remove this method and propose it for 1.19.
Removing String from types.TypeList is fine, but we should ensure that we're not breaking any (possibly debugging) output that uses %s and relies on TypeList implementing Stringer.
On the other hand, there's also a format question for types.TypeParamList.String: what exactly should it print? (actual type parameter list with square brackets and constraints? just the type parameter names?)
mknyszek
added
the
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
label
Jan 24, 2022
Issue #47916 does not document the
String
method fortypes.TypeList
(added in https://go.dev/cl/346552 to aid with debugging). Furthermore the otherwise symmetricTypeParamList
type does not have aString
method.These two list types should be symmetric. Since
types.TypeList.String
was not covered by the proposal, probably we should remove this method and propose it for 1.19.CC @griesemer
The text was updated successfully, but these errors were encountered: