Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/tour: "Run" button becomes "Kill" on compilation error #50921

Closed
enocom opened this issue Jan 31, 2022 · 1 comment
Closed

x/website/tour: "Run" button becomes "Kill" on compilation error #50921

enocom opened this issue Jan 31, 2022 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@enocom
Copy link

enocom commented Jan 31, 2022

To reproduce, visit any page with a playground on https://go.dev/tour:

  1. Write something that will not compile, e.g.,
package main

// missing close quote
import "fmt 

func main() {
	fmt.Println("Hello, World")
}
  1. Click "Run".
  2. Compilation error is reported, but the "Run" button is now stuck on "Kill"

Expected behavior:

After clicking "Run", the button should return to "Run" with a compilation error.

Image 1-30-22 at 9 52 PM

@gopherbot gopherbot added this to the Unreleased milestone Jan 31, 2022
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 4, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/478415 mentions this issue: tour: call 'done' callback after Run, on message Kind 'system'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants