Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: reconcile directoryFilters and go.work files. #52970

Open
findleyr opened this issue May 18, 2022 · 0 comments
Open

x/tools/gopls: reconcile directoryFilters and go.work files. #52970

findleyr opened this issue May 18, 2022 · 0 comments
Labels
gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@findleyr
Copy link
Member

With go.work files, gopls now has multiple ways to exclude workspace directories, and they may be disjoint or overlap. This has been a source of recent confusion (e.g. #45340).

We need a new way to reconcile which files, packages, and modules are considered part of the workspace, and we need to present this to the user more clearly.
@findleyr findleyr added the gopls/workspace Issues related to support for modules or multi-module workspaces. label May 18, 2022
@findleyr findleyr added this to the gopls/v0.9.0 milestone May 18, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 18, 2022
@findleyr findleyr modified the milestones: gopls/v0.9.0, gopls/later Jun 24, 2022
@findleyr findleyr mentioned this issue Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
2 participants
@gopherbot @findleyr