Skip to content

os/exec: TestPipeLookPathLeak fails randomly on OS X #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davecheney opened this issue May 30, 2013 · 12 comments
Closed

os/exec: TestPipeLookPathLeak fails randomly on OS X #5593

davecheney opened this issue May 30, 2013 · 12 comments
Labels
FrozenDueToAge OS-Darwin Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@davecheney
Copy link
Contributor

Darwin builders have started to occasionally fail this test

--- FAIL: TestPipeLookPathLeak (0.02 seconds)
    exec_test.go:169: leaked 4 fds; want ~0
FAIL
FAIL    os/exec 1.083s


Recent failures:
http://build.golang.org/log/5b9a4be800936ee52a6c00b1b64337ae9d4e1906
http://build.golang.org/log/5fa2f5674bc6293bf068689b4df3e3baf96810e1
@davecheney
Copy link
Contributor Author

Comment 1:

I can confirm this test failure, or more correctly, the underlying leak is present. If I
modify the finaliser attached to each os.File to complain if it is being called, ie, if
the os.File has fallen out of scope without a call to Close() and stress test this
package eventually I find a stray os.File (attached to a tcp connection) which is
probably what this test is also discovering.
At this point I haven't figured out where we are leaking the os.File (or net.Conn)

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @davecheney.

@davecheney
Copy link
Contributor Author

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added go1.2.

@davecheney
Copy link
Contributor Author

Comment 4:

Removing myself as the owner. Reviewing the failures, I think they are all for 10.6,
which points to a kernel bug.

Owner changed to ---.

@rsc
Copy link
Contributor

rsc commented Sep 10, 2013

Comment 5:

Labels changed: added testing.

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 6:

Labels changed: added go1.2maybe, removed go1.2.

@rsc
Copy link
Contributor

rsc commented Oct 2, 2013

Comment 7:

Labels changed: added go1.3, removed go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 8:

Labels changed: added release-go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 9:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 10:

Labels changed: added repo-main.

@rsc
Copy link
Contributor

rsc commented May 11, 2014

Comment 11:

Labels changed: added priority-later, release-none, suggested, removed priority-soon, release-go1.3.

@davecheney davecheney added accepted Testing An issue that has been verified to require only test changes, not just a test failure. Suggested Issues that may be good for new contributors looking for work to do. labels May 11, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc
Copy link
Contributor

rsc commented Apr 28, 2015

Per #9511, we will not be making any further bug fixes specific to 10.6.

@rsc rsc closed this as completed Apr 28, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge OS-Darwin Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants