Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: TestTransportMaxFrameReadSize failures #56806

Closed
gopherbot opened this issue Nov 17, 2022 · 5 comments
Closed

x/net/http2: TestTransportMaxFrameReadSize failures #56806

gopherbot opened this issue Nov 17, 2022 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportMaxFrameReadSize"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportMaxFrameReadSize (0.03s)
    transport_test.go:4034: maxFrameReadSize = 16384; want 64000

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportMaxFrameReadSize"
2022-11-15 19:08 linux-ppc64le-power9osu net@2f8c3d16 go@ad7dc8ad x/net/http2.TestTransportMaxFrameReadSize (log) 
--- FAIL: TestTransportMaxFrameReadSize (0.03s)
    transport_test.go:4034: maxFrameReadSize = 16384; want 64000

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2022

This test was recently added in https://go.dev/cl/362834 (attn @neild @rolandshoemaker @robaho).

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/451775 mentions this issue: http2: deflake TestTransportMaxFrameReadSize

@gopherbot gopherbot moved this to Done in Test Flakes Nov 17, 2022
@gopherbot gopherbot reopened this Nov 21, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportMaxFrameReadSize"
2022-11-16 23:25 linux-ppc64le-power9osu net@0833b635 go@b74aaa14 x/net/http2.TestTransportMaxFrameReadSize (log) 
--- FAIL: TestTransportMaxFrameReadSize (0.03s)
    transport_test.go:4034: maxFrameReadSize = 16384; want 64000

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 21, 2022

The above failure predates the fix CL.

@bcmills bcmills closed this as completed Nov 21, 2022
@golang golang locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot