Skip to content

net/http: TestWrappedResponseController failures #56961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Nov 28, 2022 · 6 comments
Closed

net/http: TestWrappedResponseController failures #56961

gopherbot opened this issue Nov 28, 2022 · 6 comments
Assignees
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
post <- pkg == "net/http" && test == "TestWrappedResponseController"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestWrappedResponseController (0.00s)
    --- FAIL: TestWrappedResponseController/h1 (0.01s)
        responsecontroller_test.go:249: ctl.Flush() = http2: stream closed, want nil

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 28, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestWrappedResponseController"
2022-11-24 04:12 dragonfly-amd64-622 go@2c7c98c3 net/http.TestWrappedResponseController (log)
--- FAIL: TestWrappedResponseController (0.00s)
    --- FAIL: TestWrappedResponseController/h1 (0.01s)
        responsecontroller_test.go:249: ctl.Flush() = http2: stream closed, want nil

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Nov 28, 2022

attn @neild; this test was unskipped in HTTP/2 mode very recently in https://go.dev/cl/449935.

@bcmills
Copy link
Contributor

bcmills commented Nov 28, 2022

This test is new as of Go 1.20 (for #54136).

Marking as release-blocker at least until we can determine whether this failure mode affects first-class ports.

@bcmills bcmills added this to the Go1.20 milestone Nov 28, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/453860 mentions this issue: net/http: deflake and fix TestWrappedResponseController

@gopherbot gopherbot moved this to Done in Test Flakes Nov 30, 2022
@gopherbot gopherbot reopened this Feb 2, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestWrappedResponseController"
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestWrappedResponseController (log)
--- FAIL: TestWrappedResponseController (0.00s)
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestWrappedResponseController (log)
--- FAIL: TestWrappedResponseController (0.00s)

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 2, 2023

The above are #58168.

@bcmills bcmills closed this as completed Feb 2, 2023
@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Archived in project
Development

No branches or pull requests

3 participants