Skip to content

net/http: TestTransportCloseResponseBody failures #58255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 2, 2023 · 6 comments
Closed

net/http: TestTransportCloseResponseBody failures #58255

gopherbot opened this issue Feb 2, 2023 · 6 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Feb 2, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportCloseResponseBody" && `too long waiting`

Issue created automatically to collect these failures.

Example (log):

1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
2023/01/26 01:38:34 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc000666000 127.0.0.1:50229 in state active
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h1 (19.43s)
        transport_test.go:2752: too long waiting for write error

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportCloseResponseBody"
2023-01-25 19:25 darwin-amd64-12_0 go@2bf0f54b net/http.TestTransportCloseResponseBody (log) 
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
2023/01/26 01:38:34 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc000666000 127.0.0.1:50229 in state active
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h1 (19.43s)
        transport_test.go:2752: too long waiting for write error
2023-01-30 17:48 darwin-amd64-12_0 go@4373c6f5 net/http.TestTransportCloseResponseBody (log) 
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h2 (15.96s)
        transport_test.go:2744: too long waiting for close
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestTransportCloseResponseBody (log) 
--- FAIL: TestTransportCloseResponseBody (0.00s)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 2, 2023

linux-amd64-race is #58168; the others are probably in the nebulous darwin cluster (attn @neild).

@bcmills bcmills added this to the Backlog milestone Feb 2, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportCloseResponseBody" && `too long waiting`
2023-02-10 17:29 darwin-amd64-13 go@1fa2deb1 net/http.TestTransportCloseResponseBody (log) 
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h2 (12.59s)
        transport_test.go:2752: too long waiting for write error
2023-02-14 18:12 darwin-amd64-10_15 go@202a1a57 net/http.TestTransportCloseResponseBody (log) 
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h1 (11.53s)
        transport_test.go:2752: too long waiting for write error
2023/02/14 15:12:41 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc001164170 127.0.0.1:50922 in state active

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportCloseResponseBody" && `too long waiting`
2023-02-27 20:25 darwin-amd64-10_15 go@b611b3a8 net/http.TestTransportCloseResponseBody (log) 
2023/03/01 06:57:33 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc000024700 127.0.0.1:50577 in state active
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h1 (16.22s)
        transport_test.go:2752: too long waiting for write error

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportCloseResponseBody" && `too long waiting`
2023-03-17 19:45 darwin-amd64-12_0 go@3ff6dbdf net/http.TestTransportCloseResponseBody (log) 
2023/03/17 18:56:00 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc00031fc00 127.0.0.1:50398 in state active
--- FAIL: TestTransportCloseResponseBody (0.00s)
    --- FAIL: TestTransportCloseResponseBody/h1 (15.05s)
        transport_test.go:2752: too long waiting for write error

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Mar 22, 2023

Fixed by CL 477196 on the main branch. (Note that the most recent linked failure is on release-branch.go1.20.)

@bcmills bcmills closed this as completed Mar 22, 2023
@bcmills bcmills self-assigned this Mar 22, 2023
@bcmills bcmills modified the milestones: Backlog, Go1.21 Mar 22, 2023
@golang golang locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot