x/tools/gopls: Feature Request: Support for "Inline Method" refactoring code action #59243
Comments
gopherbot
added
Tools
findleyr
added
FeatureRequest
|
Thanks for this request. I'm surprised it has not been requested before, but I did not find any dupes. Right now we're working on a major performance overhaul, but improved refactoring is one of our most requested features. |
|
A few considerations for the design of this feature. Let f be the candidate function.
These concerns aside, I think it would require very little effort to start with something imperfect and iterate from there. Another interesting problem is automatically simplifying the inlined body based on knowledge of the arguments. e.g. a range over a slice or map that it known to be nil can be deleted. Simplification of a block of statements might be a useful feature in its own right, independent of inlining. |
|
Change https://go.dev/cl/523696 mentions this issue: |
About once a week I look for the Inline Method refactoring in VSCode.
If this could be added that would be super!
gopls version
go env
What did you do?
Put the cursor on either of the
PrintHellos.What did you expect to see?
A 💡 with a Code Action to "Inline
PrintHello".The result should be this:
What did you see instead?
No obvious way of having
goplsinlinePrintHello()for me.Editor and settings
{ "files.exclude": { "node_modules/": true, "**/*.pyc": true }, "editor.minimap.enabled": false, "python.linting.mypyEnabled": true, "git.autofetch": true, "files.associations": { "*.1": "troff", "COMMIT_EDITMSG": "git-commit", "TAG_EDITMSG": "git-commit" }, "git.confirmSync": false, "python.linting.flake8Args": [ "--ignore=E501,W504" ], "workbench.startupEditor": "newUntitledFile", "zentabs.maximumOpenedTabs": 4, "files.trimTrailingWhitespace": true, "editor.scrollBeyondLastLine": false, "editor.codeActionsOnSave": { "source.fixAll.dart": true, "source.fixAll.eslint": true }, "go.useLanguageServer": true, "editor.cursorSurroundingLines": 4, "[javascript]": { "editor.defaultFormatter": "numso.prettier-standard-vscode" }, "workbench.editor.limit.enabled": true, "workbench.editor.limit.value": 5, "python.showStartPage": false, "[c]": { "editor.defaultFormatter": "xaver.clang-format" }, "[cpp]": { "editor.defaultFormatter": "xaver.clang-format" }, "rust-analyzer.checkOnSave.command": "clippy", "rst.preview.pythonPath": "python3", "git.countBadge": "off", "scm.countBadge": "off", "[html]": { "editor.defaultFormatter": "vscode.html-language-features" }, "liveServer.settings.donotShowInfoMsg": true, "html.autoClosingTags": false, "html.format.endWithNewline": true, "workbench.editorAssociations": { "*.ipynb": "jupyter-notebook" }, "go.toolsManagement.autoUpdate": true, "workbench.editor.untitled.hint": "hidden", "explorer.confirmDelete": false, "security.workspace.trust.untrustedFiles": "open", "notebook.cellToolbarLocation": { "default": "right", "jupyter-notebook": "left" }, "blender.executables": [ { "path": "/Applications/Blender.app/Contents/MacOS/blender", "name": "", "isDebug": false } ], "blender.allowModifyExternalPython": true, "python.linting.mypyArgs": [ "--ignore-missing-imports", "--follow-imports=silent", "--show-column-numbers", "--check-untyped-defs" ], "[dockerfile]": { "editor.defaultFormatter": "ms-azuretools.vscode-docker" }, "testExplorer.useNativeTesting": true, "python.formatting.provider": "black", "terminal.integrated.scrollback": 10000, "redhat.telemetry.enabled": true, "outline.showArrays": false, "outline.showBooleans": false, "outline.showConstants": false, "outline.showEnumMembers": false, "outline.showEnums": false, "outline.showFields": false, "outline.showKeys": false, "outline.showNull": false, "outline.showNumbers": false, "outline.showObjects": false, "outline.showOperators": false, "outline.showProperties": false, "outline.showStrings": false, "outline.showTypeParameters": false, "outline.showVariables": false, "outline.showStructs": false, "breadcrumbs.symbolSortOrder": "name", "editor.guides.bracketPairsHorizontal": false, "editor.guides.indentation": false, "editor.guides.bracketPairs": "active", "search.smartCase": true, "[dart]": { "editor.formatOnSave": true, "editor.formatOnType": true, "editor.rulers": [ 80 ], "editor.selectionHighlight": false, "editor.suggest.snippetsPreventQuickSuggestions": false, "editor.suggestSelection": "first", "editor.tabCompletion": "onlySnippets", "editor.wordBasedSuggestions": false }, "editor.fontLigatures": true, "editor.fontFamily": "Fira Code, Menlo, Monaco, 'Courier New', monospace", "dart.debugExternalPackageLibraries": true, "dart.debugSdkLibraries": true, "[json]": { "editor.defaultFormatter": "vscode.json-language-features" }, "go.lintTool": "golangci-lint", "editor.stickyScroll.enabled": true, "lldb.suppressUpdateNotifications": true, "outline.collapseItems": "alwaysCollapse", "python.linting.cwd": "", "[typescript]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, "[jsonc]": { "editor.defaultFormatter": "vscode.json-language-features" }, "javascript.format.enable": false, "typescript.format.enable": false, "[json-tmLanguage]": { "editor.defaultFormatter": "RedCMD.tmlanguage-syntax-highlighter" }, "[python]": { "editor.formatOnType": true }, "[markdown]": { "editor.defaultFormatter": "numso.prettier-standard-vscode" }, "diffEditor.renderSideBySide": false, "git.verboseCommit": true, "workbench.sideBar.location": "right" }The text was updated successfully, but these errors were encountered: