Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln/internal/vulncheck/internal/buildinfo: broken at tip #61511

Closed
heschi opened this issue Jul 21, 2023 · 7 comments
Closed

x/vuln/internal/vulncheck/internal/buildinfo: broken at tip #61511

heschi opened this issue Jul 21, 2023 · 7 comments
Assignees
@zpavlinovic
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.22

Comments

@heschi
Copy link
Contributor

heschi commented Jul 21, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck/internal/buildinfo" && test == "TestStrippedDarwin"

--- FAIL: TestStrippedDarwin (0.20s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.09s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"

across essentially all builders starting at http://go.dev/cl/506758.

cc @golang/vulndb @cherrymui
@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Jul 21, 2023
@heschi heschi added this to the Go1.22 milestone Jul 21, 2023
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Jul 21, 2023
@cherrymui
Copy link
Member

The test seems to be checking for old (buggy) behavior, maybe so it can be adjusted when needed (i.e. now). Related to #61051.

cc @zpavlinovic

@bcmills bcmills mentioned this issue Jul 25, 2023
Closed
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck/internal/buildinfo" && test == "TestStrippedDarwin"
2023-07-18 21:48 freebsd-riscv64-unmatched vuln@1568f338 go@2eca0b1e x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (2.42s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (1.16s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (1.26s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 freebsd-riscv64-unmatched vuln@1568f338 go@e713d6f9 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (2.41s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (1.14s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (1.27s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 freebsd-riscv64-unmatched vuln@1568f338 go@ffd9bd7e x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (2.40s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (1.12s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (1.28s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"

— watchflakes

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Jul 25, 2023
@zpavlinovic zpavlinovic self-assigned this Aug 7, 2023
@zpavlinovic
Copy link
Contributor

This looks it is fixed now, but will keep it open for a bit longer.

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 15, 2023
@zpavlinovic
Copy link
Contributor

The issue seems to be resolved. Closing.

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln/internal/vulncheck/internal/buildinfo" && test == "TestStrippedDarwin"
2023-07-18 21:48 darwin-amd64-11_0 vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (1.11s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.56s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.55s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 darwin-amd64-12_0 vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (0.94s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.42s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.52s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 darwin-amd64-13 vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (1.13s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.52s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.61s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 darwin-amd64-longtest vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (0.94s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.45s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.49s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 darwin-amd64-nocgo vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (0.91s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.51s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.39s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 linux-amd64-wsl vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (0.25s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.12s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.13s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
2023-07-18 21:48 linux-riscv64-unmatched vuln@1568f338 go@b02725a8 x/vuln/internal/vulncheck/internal/buildinfo.TestStrippedDarwin (log) 
--- FAIL: TestStrippedDarwin (1.16s)
    --- FAIL: TestStrippedDarwin/darwin/amd64 (0.54s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"
    --- FAIL: TestStrippedDarwin/darwin/arm64 (0.62s)
        additions_scan_test.go:109: reading go:func.*: no symbol "go:func.*"

— watchflakes

@zpavlinovic zpavlinovic reopened this Aug 22, 2023
@zpavlinovic
Copy link
Contributor

For some reason still not known to me, this is testing the vuln repo from Jul 18th. This particular test should not be failing now.

@cherrymui
Copy link
Member

The date is the commit date of the vuln repo commit, not the date where the test ran, nor the main repo commit date. This is probably newer Go commit run with an older vuln commit. I think it is probably safe to call it fixed. Thanks.

@gabyhelp gabyhelp mentioned this issue Aug 21, 2024
Closed
@golang golang locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zpavlinovic zpavlinovic

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Test Flakes
Archived in project
Milestone
Go1.22
Development

No branches or pull requests
5 participants
@zpavlinovic @bcmills @gopherbot @cherrymui @heschi