Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: Add SetFileValidData and SetFilePointerEx support #61834

Closed
kanak-clumio opened this issue Aug 8, 2023 · 5 comments
Closed

x/sys/windows: Add SetFileValidData and SetFilePointerEx support #61834

kanak-clumio opened this issue Aug 8, 2023 · 5 comments
Assignees
@kanak-clumio
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone
Unreleased

Comments

@kanak-clumio
Copy link

Currently, this package does not support SetFileValidData and SetFilePointerEx syscalls. Is there any specific reason not to have this?

Adding this support should be very straightforward.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 8, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 8, 2023

(CC @golang/windows)

@bcmills
Copy link
Contributor

bcmills commented Aug 8, 2023

SetFilePointerEx seems like an obvious addition: we already have SetFilePointer and AFAICT the only difference is the operand size.

I also see no reason not to add SetFileValidData. Want to send a CL?

@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. and removed pkgsite labels Aug 8, 2023
@kanak-clumio
Copy link
Author

Sure! I've not contributed to golang yet and am used to github and not gerrit. Let me look into setting up the repo and will create a PR with this change

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/517575 mentions this issue: Windows: Add SetFileValidData and SetFilePointerEx

@mknyszek mknyszek added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Aug 9, 2023
@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Aug 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jan 3, 2024
@dagood dagood mentioned this issue Jan 3, 2024
Open
@dtangster
Copy link

@mknyszek Do you know why this ticket issue is marked as closed? Looking at the changes, it looks like only SetFileValidData was added and not SetFilePointerEx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanak-clumio kanak-clumio

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@mknyszek @dtangster @bcmills @gopherbot @kanak-clumio