Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: tests persistently failing on ios-arm64-corellium builder #61891

Closed
bcmills opened this issue Aug 9, 2023 · 7 comments
Closed

runtime/pprof: tests persistently failing on ios-arm64-corellium builder #61891

bcmills opened this issue Aug 9, 2023 · 7 comments
Assignees
@cosnicolaou
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-iOS GOOS=ios Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 9, 2023 •
edited
Loading

Multiple tests for the runtime/pprof package have been persistently failing on the ios-arm64-corellium builder since https://go.dev/cl/503919 (for #50891). I will leave specific comments on that CL for the failures.

Failure log from https://build.golang.org/log/5e0d1538eb1f8d41d0b995ce3dd0fd647e0b8954:

--- FAIL: TestConvertCPUProfile (0.00s)
    proto_test.go:172: sample 0 = {
        	"Location": [
        		{
        			"ID": 1,
        			"Mapping": {
        				"ID": 1,
        				"Start": 4371202048,
        				"Limit": 4372922368,
        				"Offset": 0,
        				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607424,
        			"Line": null,
        			"IsFolded": false
        		},
        		{
        			"ID": 2,
        			"Mapping": {
        				"ID": 1,
        				"Start": 4371202048,
        				"Limit": 4372922368,
        				"Offset": 0,
        				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607425,
        			"Line": null,
        			"IsFolded": false
        		}
        	],
        	"Value": [
        		20,
        		40000000
        	],
        	"Label": null,
        	"NumLabel": null,
        	"NumUnit": null
        }
        want = {
        	"Location": [
        		{
        			"ID": 1,
        			"Mapping": {
        				"ID": 1,
        				"Start": 0,
        				"Limit": 0,
        				"Offset": 0,
        				"File": "",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607424,
        			"Line": null,
        			"IsFolded": false
        		},
        		{
        			"ID": 2,
        			"Mapping": {
        				"ID": 1,
        				"Start": 0,
        				"Limit": 0,
        				"Offset": 0,
        				"File": "",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607425,
        			"Line": null,
        			"IsFolded": false
        		}
        	],
        	"Value": [
        		20,
        		40000000
        	],
        	"Label": null,
        	"NumLabel": null,
        	"NumUnit": null
        }
    proto_test.go:172: sample 1 = {
        	"Location": [
        		{
        			"ID": 3,
        			"Mapping": {
        				"ID": 1,
        				"Start": 4371202048,
        				"Limit": 4372922368,
        				"Offset": 0,
        				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607488,
        			"Line": null,
        			"IsFolded": false
        		},
        		{
        			"ID": 4,
        			"Mapping": {
        				"ID": 1,
        				"Start": 4371202048,
        				"Limit": 4372922368,
        				"Offset": 0,
        				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607489,
        			"Line": null,
        			"IsFolded": false
        		}
        	],
        	"Value": [
        		40,
        		80000000
        	],
        	"Label": null,
        	"NumLabel": null,
        	"NumUnit": null
        }
        want = {
        	"Location": [
        		{
        			"ID": 3,
        			"Mapping": {
        				"ID": 1,
        				"Start": 0,
        				"Limit": 0,
        				"Offset": 0,
        				"File": "",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607488,
        			"Line": null,
        			"IsFolded": false
        		},
        		{
        			"ID": 4,
        			"Mapping": {
        				"ID": 1,
        				"Start": 0,
        				"Limit": 0,
        				"Offset": 0,
        				"File": "",
        				"BuildID": "",
        				"HasFunctions": true,
        				"HasFilenames": false,
        				"HasLineNumbers": false,
        				"HasInlineFrames": false
        			},
        			"Address": 4372607489,
        			"Line": null,
        			"IsFolded": false
        		}
        	],
        	"Value": [
        		40,
        		80000000
        	],
        	"Label": null,
        	"NumLabel": null,
        	"NumUnit": null
        }
--- FAIL: TestConvertMemProfile (0.00s)
    --- FAIL: TestConvertMemProfile/heap (0.00s)
        protomem_test.go:81: sample 0 = {
            	"Location": [
            		{
            			"ID": 1,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607424,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 2,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607488,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		2050,
            		2099200,
            		1537,
            		1574400
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			1024
            		]
            	},
            	"NumUnit": null
            }
            want = {
            	"Location": [
            		{
            			"ID": 1,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607424,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 2,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607488,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		2050,
            		2099200,
            		1537,
            		1574400
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			1024
            		]
            	},
            	"NumUnit": null
            }
        protomem_test.go:81: sample 1 = {
            	"Location": [
            		{
            			"ID": 3,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607489,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 4,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607490,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		1,
            		829411
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
            want = {
            	"Location": [
            		{
            			"ID": 3,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607489,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 4,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607490,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		1,
            		829411
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
        protomem_test.go:81: sample 2 = {
            	"Location": [
            		{
            			"ID": 5,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607425,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 6,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607426,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 7,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607491,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		0,
            		0
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
            want = {
            	"Location": [
            		{
            			"ID": 5,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607425,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 6,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607426,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 7,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607491,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		0,
            		0
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
    --- FAIL: TestConvertMemProfile/allocs (0.00s)
        protomem_test.go:81: sample 0 = {
            	"Location": [
            		{
            			"ID": 1,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607424,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 2,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607488,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		2050,
            		2099200,
            		1537,
            		1574400
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			1024
            		]
            	},
            	"NumUnit": null
            }
            want = {
            	"Location": [
            		{
            			"ID": 1,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607424,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 2,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607488,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		2050,
            		2099200,
            		1537,
            		1574400
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			1024
            		]
            	},
            	"NumUnit": null
            }
        protomem_test.go:81: sample 1 = {
            	"Location": [
            		{
            			"ID": 3,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607489,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 4,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607490,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		1,
            		829411
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
            want = {
            	"Location": [
            		{
            			"ID": 3,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607489,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 4,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607490,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		1,
            		829411
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
        protomem_test.go:81: sample 2 = {
            	"Location": [
            		{
            			"ID": 5,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607425,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 6,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607426,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 7,
            			"Mapping": {
            				"ID": 1,
            				"Start": 4371202048,
            				"Limit": 4372922368,
            				"Offset": 0,
            				"File": "/private/var/tmp/workdir-host-ios-arm64-corellium-ios/tmp/go-build3448104528/b108/pprof.test",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607491,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		0,
            		0
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
            want = {
            	"Location": [
            		{
            			"ID": 5,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607425,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 6,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607426,
            			"Line": null,
            			"IsFolded": false
            		},
            		{
            			"ID": 7,
            			"Mapping": {
            				"ID": 1,
            				"Start": 0,
            				"Limit": 0,
            				"Offset": 0,
            				"File": "",
            				"BuildID": "",
            				"HasFunctions": true,
            				"HasFilenames": false,
            				"HasLineNumbers": false,
            				"HasInlineFrames": false
            			},
            			"Address": 4372607491,
            			"Line": null,
            			"IsFolded": false
            		}
            	],
            	"Value": [
            		1,
            		829411,
            		0,
            		0
            	],
            	"Label": null,
            	"NumLabel": {
            		"bytes": [
            			524288
            		]
            	},
            	"NumUnit": null
            }
--- FAIL: TestVMInfo (0.00s)
    vminfo_darwin_test.go:56: exec: "vmmap": executable file not found in $PATH
FAIL
FAIL	runtime/pprof	15.409s

(attn @cosnicolaou @cherrymui; CC @golang/runtime @golang/ios)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) compiler/runtime Issues related to the Go compiler and/or runtime. OS-iOS GOOS=ios labels Aug 9, 2023
@bcmills bcmills added this to the Go1.22 milestone Aug 9, 2023
@bcmills bcmills mentioned this issue Aug 9, 2023
Closed
@cosnicolaou
Copy link
Contributor

I'll take a look right now.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/517795 mentions this issue: runtime/pprof: fix build breakage on ios

@cosnicolaou
Copy link
Contributor

I just mailed https://go-review.googlesource.com/c/go/+/517795. Hopefully this does the trick but I have non means of testing it directly. How do I see the builder output? Or better yet, are there instructions on how to run the ios tests on an M1 laptop?

@bcmills
Copy link
Contributor Author

bcmills commented Aug 9, 2023

Adding TRY=ios when setting Run-TryBot to +1 will run the builder (and post its output if it fails).

I'm not sure how to run the ios tests on an M1. 🤷‍♂️

@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Aug 9, 2023
@cosnicolaou
Copy link
Contributor

I'm sorry, but gerrit is a mystery to me - how do I set the Run-TryBot +1 etc? Maybe I don't have permissions to do so?

@cosnicolaou
Copy link
Contributor

yep, looks like I don't have permissions to do so.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/518315 mentions this issue: runtime/pprof: don't run TestVMInfo on ios

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Aug 10, 2023
@golang golang locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cosnicolaou cosnicolaou

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-iOS GOOS=ios Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @cosnicolaou