Skip to content

x/telemetry/internal/counter: TestWeekendsNewUser and TestWeekendsOldUser persistently failing on wasip1/wasm #62704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Sep 18, 2023 · 2 comments
Closed

x/telemetry/internal/counter: TestWeekendsNewUser and TestWeekendsOldUser persistently failing on wasip1/wasm #62704

bcmills opened this issue Sep 18, 2023 · 2 comments
Assignees
@pjweinb
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 18, 2023

https://build.golang.org/log/07c57c3bda47aefe530c5cb2c959d98cf583f203:

--- FAIL: TestWeekendsNewUser (0.05s)
    counter_test.go:302: delta 0, expected 7<delta<=14
    counter_test.go:302: weekends Sunday unexpecteledy not end day Monday
…
--- FAIL: TestWeekendsOldUser (0.08s)
    counter_test.go:306: delta 0, expected 0<delta<=7
    counter_test.go:306: weekends Sunday unexpecteledy not end day Monday
…
FAIL
FAIL	golang.org/x/telemetry/internal/counter	8.878s

There is also a typo in the error message (“unexpecteledy”).

(attn @pjweinbgo @hyangah @golang/wasm)
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues telemetry x/telemetry issues labels Sep 18, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 18, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Sep 18, 2023

This test seems to have been failing on this platform ever since it was added in https://go.dev/cl/520455.

@bcmills bcmills mentioned this issue Sep 18, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/529335 mentions this issue: internal/counter: don't test on unsupported platforms

@golang golang locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjweinb pjweinb

Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @pjweinb @gopherbot