x/tools/gopls: add uber-go/nilaway to the set of analyzers

[blacktop]

The primary reason I get bit by unexpected crashes is often getting nil or array bounds errors. I believe this could help a lot of others as well.

It'd be cool to add support for https://github.com/uber-go/nilaway and have the Problems UI point to these errors.

Using via the CLI works, but this feels like it'd make a good addition to the linters/error checks offered in vscode-go

[hyangah]

Current recommendation is to integrate through meta linters like golangci-lint or custom linter.
Unfortunately, it looks like the feature request is currently closed due to too many false positives. golangci/golangci-lint#4045

[hyangah]

We moved this issue to the gopls issue tracker since vscode-go doesn't plan to add any custom analyzer directly through the extension. We still need to investigate if its false report rate meets the quality standard we expect from gopls analyzers. If its false report rate is too high, either it needs to wait for the custom analyzer support (for example #59869), or alternatively, set up a custom linter and configure the extension to call it using the go.lintTool setting.

[blacktop]

thanks!

[blacktop]

whoops closed because I thought a new issue was created 😬

[moogacs]

I've created a custom plugin to be used locally and in GHA