Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/guru: TestIssue17515 failing on x_tools-gotip-wasip1-wasm_wasmtime due to symlink permission error #64702

Closed
bcmills opened this issue Dec 13, 2023 · 1 comment
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 13, 2023

Go version

N/A

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

Check LUCI build status at https://ci.chromium.org/p/golang/g/x-tools-gotip/console.

What did you expect to see?

All tests passing.

What did you see instead?

https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-wasip1-wasm_wasmtime/b8761809133576738257/test-results:

=== RUN   TestIssue17515
    unit_test.go:56: symlink /tmp/home2806657382/go/src /tmp/home2806657382/src: Operation not permitted
--- FAIL: TestIssue17515 (0.00s)

This test attempts to guard the os.Symlink call based on GOOS, but it uses a negative list instead of a positive one, so erroneously assumes that new or unrecognized GOOS values support symlinks:
https://cs.opensource.google/go/x/tools/+/master:cmd/guru/unit_test.go;drc=559c4300daa4efe55422df9bba86d125cdf1d9ef;l=57

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 13, 2023
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. and removed Tools This label describes issues relating to any tools in the x/tools repository. labels Dec 13, 2023
@bcmills bcmills self-assigned this Dec 13, 2023
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Dec 13, 2023
@bcmills bcmills changed the title x/tools/cmd/guru: TestIssue17515 failing on x_tools-gotip-wasip1-wasm_wasmtime due to x/tools/cmd/guru: TestIssue17515 failing on x_tools-gotip-wasip1-wasm_wasmtime due to symlink permission error Dec 13, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/549555 mentions this issue: cmd/guru,internal/robustio: make tests robust to os.Symlink errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants