You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bcmills opened this issue
Dec 13, 2023
· 1 comment
Assignees
Labels
NeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.
bcmills
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
Tools
This label describes issues relating to any tools in the x/tools repository.
labels
Dec 13, 2023
bcmills
added
the
Testing
An issue that has been verified to require only test changes, not just a test failure.
label
Dec 13, 2023
bcmills
changed the title
x/tools/cmd/guru: TestIssue17515 failing on x_tools-gotip-wasip1-wasm_wasmtime due to
x/tools/cmd/guru: TestIssue17515 failing on x_tools-gotip-wasip1-wasm_wasmtime due to symlink permission error
Dec 13, 2023
NeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.
Go version
N/A
What operating system and processor architecture are you using (
go env
)?What did you do?
Check LUCI build status at https://ci.chromium.org/p/golang/g/x-tools-gotip/console.
What did you expect to see?
All tests passing.
What did you see instead?
https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-wasip1-wasm_wasmtime/b8761809133576738257/test-results:
This test attempts to guard the
os.Symlink
call based onGOOS
, but it uses a negative list instead of a positive one, so erroneously assumes that new or unrecognizedGOOS
values support symlinks:https://cs.opensource.google/go/x/tools/+/master:cmd/guru/unit_test.go;drc=559c4300daa4efe55422df9bba86d125cdf1d9ef;l=57
The text was updated successfully, but these errors were encountered: