x/exp/protoveneer/cmd/protoveneer: TestGeneration failing due to spurious update to copyright year

[bcmills]

Go version

c95fe91

What operating system and processor architecture are you using (go env)?

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "./..."] and env ["HOSTNAME=buildlet-linux-amd64-bullseye-rn05739ee" "HOME=/root" "SHLVL=0" "DEBIAN_FRONTEND=noninteractive" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://gk3-services-nap-jetxd907-8f582974-hv4r.c.symbolic-datum-552.internal:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache" "GOPLSCACHE=/workdir/goplscache" "PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "PWD=/workdir/gopath/src/golang.org/x/exp"] in dir /workdir/gopath/src/golang.org/x/exp

What did you do?

Check builder status at https://build.golang.org/.

What did you expect to see?

All tests passing (per #11811).

What did you see instead?

wrote testdata/basic/basic_veneer.gen.go
--- FAIL: TestGeneration (0.00s)
    --- FAIL: TestGeneration/basic (0.00s)
        protoveneer_test.go:53: diff (-want, +got):
              strings.Join({
              	"// Copyright 202",
            - 	"3",
            + 	"4",
              	" Google LLC\n//\n// Licensed under the Apache License, Version 2.0",
              	" (the \"License\");\n// you may not use this file except in complia",
              	... // 6656 identical bytes
              }, "")
FAIL
FAIL	golang.org/x/exp/protoveneer/cmd/protoveneer	0.006s

(attn @jba @eliben)

[bcmills]

This test was added very recently (in https://go.dev/cl/549635).

[bcmills]

This test is failing at HEAD because the tool is changing the file's copyright to 2024.

In general the copyright year listed in the header of a source file should be the year it was authored, not the year of its most recent minor update, so this seems like a defect in the tool itself — not just the test.

[jba]

Fixed by https://go.dev/cl/554718.