x/tools/gopls/internal/cache: TestZeroConfigAlgorithm failing on wasm builders

[bcmills]

Go version

2c35def

Output of go env in your module/workspace:

N/A

What did you do?

View https://ci.chromium.org/p/golang/g/x-tools-gotip/console

What did you see happen?

Failures for all wasm platforms:

• js: https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-js-wasm/b8757980955903953457/overview
• wasip1: https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-wasip1-wasm_wazero/b8757980953151405937/overview

--- FAIL: TestZeroConfigAlgorithm (0.43s)
--- FAIL: TestZeroConfigAlgorithm/basic_AdHoc_workspace (0.02s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/basic_GOPATH_workspace (0.04s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/basic_go.mod_workspace (0.06s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/basic_go.work_workspace (0.06s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/go.work_from_env (0.02s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/independent_module_view (0.02s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/multi-folder_workspace (0.02s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/multi-module_workspace (0.03s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/multiple_go.work (0.03s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/multiple_go.work,_c_unused (0.03s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/unified_workspace (0.03s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/zero-config_open_module (0.02s)
    session_test.go:253: fetching env: <nil>
--- FAIL: TestZeroConfigAlgorithm/zero-config_open_modules (0.03s)
    session_test.go:253: fetching env: <nil>
FAIL
FAIL	golang.org/x/tools/gopls/internal/cache	2.264s

What did you expect to see?

All tests either passing or skipped on the configured builders.

I suspect that this test just needs a call to testenv.NeedsGoPackages or similar.

(attn @findleyr)

[gopherbot]

Change https://go.dev/cl/559155 mentions this issue: gopls/internal/cache: skip TestZeroConfigAlgorithm on wasm