Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/cmd/golangorg: TestAll failing as of CL 588977 #68575

Closed
dmitshur opened this issue Jul 24, 2024 · 2 comments
Closed

x/website/cmd/golangorg: TestAll failing as of CL 588977 #68575

dmitshur opened this issue Jul 24, 2024 · 2 comments
Assignees
@dmitshur
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Go1.24

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 24, 2024 •
edited
Loading 

=== RUN   TestAll
    server_test.go:215: GET https://go.dev/doc/go1.24: found link to https://go.dev/issue/67699, should be /issue/67699
    server_test.go:215: GET https://go.dev/doc/next: found link to https://go.dev/issue/67699, should be /issue/67699
--- FAIL: TestAll (49.77s)

E.g., https://ci.chromium.org/b/8741582152981626753.

CL 588977 (CC @randall77) used an absolute rather than relative link in doc/next/3-tools.md, which unfortunately isn't caught by any test in the main Go repo but only in the x/website one.

It'd be good to copy that test or do something equivalent to avoid further occurrences—filed #68633 for that.
@dmitshur dmitshur added Documentation NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Jul 24, 2024
@dmitshur dmitshur added this to the Go1.24 milestone Jul 24, 2024
@dmitshur dmitshur self-assigned this Jul 24, 2024
@dmitshur dmitshur mentioned this issue Jul 24, 2024
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600656 mentions this issue: doc/next: use relative link to Go issue

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600816 mentions this issue: WIP: cmd/relnote: add test to check links for problems

@dmitshur dmitshur mentioned this issue Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot