cmd/go: go test flag -skip should be cacheable

[zgzhong]

Proposal Details

Running tests with the -skip flag should be able to use the test result cache.

In the original design of the test result cache (#11193), the test flag -run is a cacheable flag. However, the subsequent proposal (#41583) that added the -skip flag to go test but did not make it cacheable.

Both -skip and -run are flags used to match or filter the test cases. Since the -run parameter is cacheable, the -skip parameter should also be cacheable, too.

[gabyhelp]

Related Issues

• proposal: cmd/go: add flag `go test -no-cache` #39056 (closed)
• proposal: cmd/go: go test: allow `-run` and `-skip` flags to specify a package #68401 (closed)
• cmd/go: -benchtime flag should be cacheable #44555 (closed)
• proposal: testing: flag show skipped #34306 (closed)
• proposal: testing: add a flag to detect unnecessary skips #25951
• cmd/go: doc mentions "cacheable flag" but never lists them #42544 (closed)
• cmd/go: go test flag `-failfast` should be cacheable #47355 (closed)
• cmd/go: "help test" caching paragraph is out-of-date and potentially misleading #48484
• testing: enforce -skip in example tests #61491 (closed)
• cmd/go: -exec prevents test caching #27207

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[matloob]

Yeah, I can't think of a reason to not cache it.

[seankhliao]

does this need to be a proposal or just a change?

[rsc]

This is a bug; it does not need a proposal.

[matloob]

I'll send a CL for this. Thanks!

[gopherbot]

Change https://go.dev/cl/646997 mentions this issue: cmd/go: add '-skip' to list of cacheable test flags