Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/goimports,gopls: avoid deprecated symbols and/or packages #70736

Open
findleyr opened this issue Dec 9, 2024 · 0 comments
Open

x/tools/cmd/goimports,gopls: avoid deprecated symbols and/or packages #70736

findleyr opened this issue Dec 9, 2024 · 0 comments
Labels
gopls/imports gopls Issues related to the Go language server, gopls.
Milestone
gopls/backlog

Comments

@findleyr
Copy link
Member

findleyr commented Dec 9, 2024 •
edited
Loading

Skimming the codebase, it look like we don't consider API deprecation in goimports. That is surprising.

We should avoid deprecated symbols and packages as import candidates.

Edit: context is #70717, where a user imported x/exp/maps by accident. (Though, will note that x/exp/maps is not currently deprecated).

CC @pjweinb
@findleyr findleyr added this to the gopls/backlog milestone Dec 9, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 9, 2024
@findleyr findleyr removed the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/imports gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
2 participants
@gopherbot @findleyr