x/tools/gopls: Rename: "unexpected composite literal type %T: %v" panic in satisfy.(*Finder).Find

[adonovan]

#!stacks
"runtime.gopanic" && "satisfy.(*Finder).expr:+65"

Issue created by stacks.

This crash indicates that satisfy was called on ill-typed code. Perhaps the best fix is to wait until #70638 is available and then change rename to avoid using the satisfy package entirely, as the type-checker will record this information as it goes.

This stack k3L0Og was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+65
• golang.org/x/tools/refactor/satisfy.(*Finder).call:+26
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19
• golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27
• golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178
• golang.org/x/tools/gopls/internal/golang.(*renamer).check:+16
• golang.org/x/tools/gopls/internal/golang.renameObjects:+24
• golang.org/x/tools/gopls/internal/golang.renameExported:+56
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+157
• golang.org/x/tools/gopls/internal/golang.Rename:+24
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+489

golang.org/x/tools/gopls@v0.17.1 go1.23.4 darwin/arm64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: Rename: crash due to Info.Defs[id]=nil bug in checkStructField #70968
• x/tools/gopls: gopls fails to rename all uses of instantiated struct field #61640 (closed)
• x/tools/gopls: crash when renaming in a package using builtins with type parameters #52940 (closed)
• x/tools/gopls: crash in renaming inside packages that use type param composite lits #61614 (closed)
• x/tools/gopls: crash during renaming #53277 (closed)
• x/tools/gopls: rename fails on struct method that references bad struct field #32882 (closed)
• x/tools/gopls: Completion: failed type assertion in completer.item #71044 (closed)
• x/tools/gopls: crash with unexpected composite literal type (redux) #61813 (closed)
• x/tools/gopls: "edit does not belong to syntax of package %q" bug in golang.Rename #70049
• x/tools/gopls: rename crashes on builtin types #32992 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}