-
Notifications
You must be signed in to change notification settings - Fork 1.6k
remove inappropriate transitive dependencies by splitting conformance
into a separate module
#806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We should just delete the conformance test. It hasn't been run in forever, and most of the new shiny stuff is in v2 anyways (along with a eventually better written conformance test). |
Back-tracking a bit, it seems that the real issue is that Thus, we should really move |
That's fair, but I think for now let's stop the bleeding by cutting out the |
Fixed by #808. |
#804 reports an error with
go get -u
for this module.The problem arises through a large transitive dependency graph, introduced via a dependency on
google.golang.org/genproto
(and eventuallygoogle.golang.org/grpc
and its wide net of dependencies) in theconformance/internal/conformance_proto
package:However, the
conformance
subtree doesn't even build usingcmd/go
: it has its ownMakefile
and.sh
test driver. It should not be included in the main module, and then the inappropriategrpc
dependency will be removed.That will also help to address golang/lint#436.
CC @dmitshur @thepudds
The text was updated successfully, but these errors were encountered: