{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27146054,"defaultBranch":"master","name":"tools","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-25T21:07:26.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725897134.0","currentOid":""},"activityList":{"items":[{"before":"8db95625fc21e15eb02b92fbb607395d1b8723e6","after":"c8d229cde80361a35046e2b24705a66ed7cba922","ref":"refs/heads/master","pushedAt":"2024-09-18T20:18:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix spelling errors\n\nReported originally in CL 611915 (vscode-go PR 3529).\n\nAnd ran golangci-lint misspell checker to find a couple more.\n\nChange-Id: I2dac2901191cc8759f0bd6b2084b61dbba174dd6\nReviewed-on: https://go-review.googlesource.com/c/tools/+/614156\nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"all: fix spelling errors"}},{"before":"bea7373d8a8268c2e3a260c1b8d41f96c4f7489e","after":"8db95625fc21e15eb02b92fbb607395d1b8723e6","ref":"refs/heads/master","pushedAt":"2024-09-18T19:41:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: update public doc of CreatePackage\n\nChange-Id: I6ae61513717bac0bd756b612f0a843d55f1df296\nGitHub-Last-Rev: 734464cdb3494e049c0ea9d0ea4786b4583605e3\nGitHub-Pull-Request: golang/tools#520\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613159\nReviewed-by: Carlos Amedee \nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ssa: update public doc of CreatePackage"}},{"before":"18a3f0501fe5eab5f11d327e6cbace73ecd5958b","after":"bea7373d8a8268c2e3a260c1b8d41f96c4f7489e","ref":"refs/heads/master","pushedAt":"2024-09-18T14:43:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/protocol/command: remove nuisance error handling\n\nThe various command.NewXXXCommand functions all used to return\nan error in case argument marshalling failed. However, in 100%\nof cases, the particular argument types have infallible JSON\nmarshalling. This change emits the error handling code only\nin the fallible cases (none yet).\n\nAlso, the New functions now return a pointer to a Command,\n(as they should), simplifying surrounding logic.\n\n(This is a preparatory cleanup for CL 612495.)\n\nChange-Id: I2dac9f84034c2fade2ca05adc62129afc78e1cfe\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613263\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/protocol/command: remove nuisance error handling"}},{"before":"03550136e73c7071ff57e5d1fbaf18351a139c1a","after":"18a3f0501fe5eab5f11d327e6cbace73ecd5958b","ref":"refs/heads/master","pushedAt":"2024-09-18T13:30:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: remove outdated any normalizer setting up in test\n\nRemove the outdated normalizer for formatting interface{} as\nany during tests.\n\n* another benefit is we remove the un-exported test function from\n example, it's clearer for pkgsite and godoc users.\n\nChange-Id: Ibc0513e7487a278b1275de804aa8bd3b444a5496\nGitHub-Last-Rev: 40157a997042438fd0e1c624314f7b7de7926cd0\nGitHub-Pull-Request: golang/tools#522\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613161\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King ","shortMessageHtmlLink":"go/ssa: remove outdated any normalizer setting up in test"}},{"before":"2aabc4f3849cc8660f482f05a64c1b6dc6dd1628","after":"03550136e73c7071ff57e5d1fbaf18351a139c1a","ref":"refs/heads/master","pushedAt":"2024-09-17T20:37:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: sanity check for package transient fields\n\nChange-Id: I96badb1a6c4f3737a30e3a5fc5c458a1a64264bf\nGitHub-Last-Rev: 9a332833af2a63cbedd9e8d3f1061fcba09c611e\nGitHub-Pull-Request: golang/tools#519\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613158\nCommit-Queue: Alan Donovan \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"go/ssa: sanity check for package transient fields"}},{"before":"5cb6eeba24d865cf2ebaedee042b6489349ef003","after":"2aabc4f3849cc8660f482f05a64c1b6dc6dd1628","ref":"refs/heads/master","pushedAt":"2024-09-17T19:40:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/analysis/passes/printf: return when suppressing a non-constant diagnostic\n\nChange-Id: Ied134c5e3b3414253de02f3ac4f8a7f73e9427ed\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613516\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"go/analysis/passes/printf: return when suppressing a non-constant dia…"}},{"before":"e603756b2be22dc76f8a447c322fddce24fbb865","after":"5cb6eeba24d865cf2ebaedee042b6489349ef003","ref":"refs/heads/master","pushedAt":"2024-09-17T19:37:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"txtar: use slices.Clone instead of copy\n\nUse slices.Clone instead of copy now that x/tools uses Go >= 1.22.\nResolves an outstanding TODO.\n\nChange-Id: Ia87f18e5e51f35dda5056538b9d0d0699c514ffc\nGitHub-Last-Rev: 468e40586d31158dad1d06c8171bc4f857ec785c\nGitHub-Pull-Request: golang/tools#523\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613835\nReviewed-by: Michael Matloob \nReviewed-by: Sam Thanawalla \nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"txtar: use slices.Clone instead of copy"}},{"before":"42b921c744d11437d952433416e7bd7957665196","after":"e603756b2be22dc76f8a447c322fddce24fbb865","ref":"refs/heads/master","pushedAt":"2024-09-17T18:54:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: add telemetry counter for GOPACKAGESDRIVER\n\nUpdate a counter each time we observe a gopackages driver in\nuse. This will help us understand the conditions that led to\nsome crashes reported by telemetry.\n\nUpdates golang/go#60890\n\nChange-Id: Ieca522c22b6f5bc9756210627bba82934946eaf8\nReviewed-on: https://go-review.googlesource.com/c/tools/+/594955\nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/cache: add telemetry counter for GOPACKAGESDRIVER"}},{"before":"a58d83bcd94176a458978303f4a2e83999725004","after":"42b921c744d11437d952433416e7bd7957665196","ref":"refs/heads/master","pushedAt":"2024-09-17T18:32:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/test/integration: skip BenchmarkPackages with -short\n\nThe new BenchmarkPackages test is failing on the perf builder, because\nthe gopls.packages command is not supported by gopls@v0.11.0. By\nconvention, skip this benchmark with -short to filter it out from the\nset of benchmarks run by x/benchmarks.\n\nChange-Id: I5e6cc22212644be0a4fc2e6d8f4ce0f282330e00\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613718\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/test/integration: skip BenchmarkPackages with -short"}},{"before":"765ea95f2b7d5d3710b14b8883b2300cd1f2c103","after":"a58d83bcd94176a458978303f4a2e83999725004","ref":"refs/heads/master","pushedAt":"2024-09-17T17:12:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: build the import map lazily during type checking\n\nFor larger repositories, a significant amount of time in the importer is\nspent building the import map.\n\nWhile we don't really want to persist these import maps, which can be\nquite large, we can largely eliminate their cost by doing an incremental\nbreadth-first search of dependencies for the desired import path: most\nimports are direct or found within a shallow search starting from the\noriginal package.\n\nAs one reference point, the DiagnoseChange/kubernetes benchmark went\nfrom 10% of CPU spent in importMap, to ~0% in importLookup.\n\nChange-Id: I219aa6b7d41dfb11ec5d8a5e3819adc46dd37f2d\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613715\nAuto-Submit: Robert Findley \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/cache: build the import map lazily during type checking"}},{"before":"a319a85de8864a4d2a2f8b00ba67bc706a1a6b6a","after":"765ea95f2b7d5d3710b14b8883b2300cd1f2c103","ref":"refs/heads/master","pushedAt":"2024-09-16T22:55:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/analysis/passes/printf: add global to disable new diagnostics\n\nAdds a global to allow for disabling the new constant format string\nfor Printf calls. This is to allow for easier staged upgrades of\nx/tools.\n\nChange-Id: I5dc0d88cf6328a68e8994010e388366102afc892\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613655\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/analysis/passes/printf: add global to disable new diagnostics"}},{"before":"5aac53c5ff1eeca116f7aad04dde7f9acf76e928","after":"a319a85de8864a4d2a2f8b00ba67bc706a1a6b6a","ref":"refs/heads/master","pushedAt":"2024-09-16T22:13:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/telemetry/cmd/stacks: display closed issues white\n\nThe isTerminal implementation works for our dev machines,\n{darwin,linux} x {amd64,arm}, and avoids a dependency\non x/term, which gopls so far doesn't need... though I\nam now tempted to find a pretext for the dependency.\n\nChange-Id: If96b5cf737c9ea998d0612dec294295a5528b22a\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613575\nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/telemetry/cmd/stacks: display closed issues white"}},{"before":"8fcd92f832cbbe49e198c7574af755362816ed64","after":"5aac53c5ff1eeca116f7aad04dde7f9acf76e928","ref":"refs/heads/master","pushedAt":"2024-09-16T20:58:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: Definition: jump to assembly\n\nThis CL adds support for jumping to the definition of a function\nimplemented in assembly. The first Definition query jumps to the\nGo declaration, as usual; this func has no body. Executing a\nsecond Definition query jumps to the assembly implementation,\nif found.\n\n+ Test, doc, relnote\n\nFixes golang/go#60531\n\nChange-Id: I943a05d4a2a5b6a398450131831f49cc7c0754e4\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612537\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang: Definition: jump to assembly"}},{"before":"7891473c0188eacbae86ac0ddd94af6f8c407534","after":"8fcd92f832cbbe49e198c7574af755362816ed64","ref":"refs/heads/master","pushedAt":"2024-09-16T15:24:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/telemetry/cmd/stacks: predicate de-duplication\n\nThis CL introduces an expression language for matching\nstacks, inspired by watchflakes. Each issue has a block\nat the start of its body of this form:\n\n ```\n #!stacks\n \"bug.Reportf\" && \"golang.Hover:+19\"\n ```\n\nwhere the expression is a sentence of this grammar:\n\n expr = \"string literal\"\n | ( expr )\n | expr && expr\n | expr || expr\n | ! expr\n\nA string literal implies a substring match against\na stack trace; the other forms are boolean operations.\nThe stacks command reads all such predicates at start,\nand uses them to associate new stacks with existing\nissues. (It reports an error if a stack is claimed by\ntwo issues.) For each claim, it updates the issue\nby adding a comment describing all the new stacks\n(example: https://github.com/golang/go/issues/60890#issuecomment-2350023305)\nand it adds/updates the \"Dups: \" list on the last\nline of the issue body (first comment).\n\nThis should greatly reduce the amount of toil in\nassociating stacks with issues, since we can just\ntweak the predicates to accommodate minor variations.\n\nThe GitHub auth token now needs R/W access to golang/go issues.\n\nFixes golang/go#65963\n\nChange-Id: I836cd89bba456826839a389271ac38745e493a54\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613215\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/telemetry/cmd/stacks: predicate de-duplication"}},{"before":"91d4bdb347baf3a1685f94c3de8054bd46e6c97a","after":"7891473c0188eacbae86ac0ddd94af6f8c407534","ref":"refs/heads/master","pushedAt":"2024-09-16T14:01:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/telemetry/cmd/stacks: fix two bugs\n\n1. There were three early returns in the frame -> URL\n computation, though it was hard to see, and their\n formatting logic differed. This CL factors them,\n extracting the frameURL function.\n\n2. When git clone fails (e.g. due to no SSO cert),\n we failed to clean up the empty dir, causing a\n persistently stuck failure state. Now we attempt\n to clean up the directory. (This won't help when\n the program is terminated from without.)\n\nChange-Id: I0f7e2dd26b95899ec85b3e4666def374dc8caadd\nReviewed-on: https://go-review.googlesource.com/c/tools/+/613076\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/telemetry/cmd/stacks: fix two bugs"}},{"before":"198986d2ddbacf9079af2ab61e6e24fda15631a1","after":"91d4bdb347baf3a1685f94c3de8054bd46e6c97a","ref":"refs/heads/master","pushedAt":"2024-09-13T18:33:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: rm GofumptFormat from internal/settings\n\nSince CL 612055 var GofumptFormat can never be nil, and since CL 609655\nit is a very simple wrapper.\n\nRemove it, and use mvdan.cc/gofumpt/format directly in internal/golang.\n\nNote that this removes some documentation bits about gofumpt options, but\nthose are already described in internal/golang.Format inline comments.\n\nChange-Id: Ic7d5b8412e913f2dbbc14befb978f8a4f743334a\nReviewed-on: https://go-review.googlesource.com/c/tools/+/611844\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Findley \nReviewed-by: Robert Findley \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls: rm GofumptFormat from internal/settings"}},{"before":"3e491913401c266a6e709646ec9be5c67a47fe20","after":"198986d2ddbacf9079af2ab61e6e24fda15631a1","ref":"refs/heads/master","pushedAt":"2024-09-12T20:01:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: go/ssa: disable TestTypeparamTest on wasm\n\nwatchflakes reported additional test cases for TestTypeparamTest on\nwasm. Skipping the test when on wasm.\n\nFixes golang/go#69410\nFixes golang/go#69409\n\nChange-Id: Icfe5da007bf7411e9875313bc1b190751f1c1a15\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612855\nCommit-Queue: Tim King \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Tim King ","shortMessageHtmlLink":"go/ssa: go/ssa: disable TestTypeparamTest on wasm"}},{"before":"beed481fb54ead699f9619d6ae6bd247035d8d5a","after":"3e491913401c266a6e709646ec9be5c67a47fe20","ref":"refs/heads/master","pushedAt":"2024-09-12T19:13:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/telemetry/cmd/stacks: generate CodeSearch links\n\nThis CL causes the stacks command to mark up each stack as a\nset of links to CodeSearch. In order to do that, it needs to\nbuild the gopls executable at the correct version of gopls and Go\nand for the right GOOS and GOARCH, read the pclntab out of the\nexecutable (which is the only authority on how to decode the\nsymbol names that appear in the stack counter), and then\nconstruct CodeSearch URLs from (version, file, line) triples.\n\nThe expensive steps are cached in /tmp/gopls-stacks so that they\nare paid infrequently in a typical stacks run.\n\nSee https://github.com/golang/go/issues/67288 for an example\nof the updated output.\n\nFixes golang/go#64654\n\nChange-Id: If1c3e42af5550114515b47a22dfa036e8da27143\nReviewed-on: https://go-review.googlesource.com/c/tools/+/611840\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/telemetry/cmd/stacks: generate CodeSearch links"}},{"before":"15b8886a84d5cf396f39e693ae05c4f1f87a1a9e","after":"beed481fb54ead699f9619d6ae6bd247035d8d5a","ref":"refs/heads/master","pushedAt":"2024-09-12T17:34:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/settings: use CodeActionKind hierarchy\n\nThis change causes all CodeActions returned by gopls to use a\nspecific leaf type such as refactor.inline.call, instead of a\ngeneral category such as refactor or refactor.inline. The\ncategories may continue to be specified in the \"Only\" parameter\nof a CodeActions request, and they apply hierarchically.\nThis allows clients to be more specific in requesting a\nparticular Code Action.\n\nDetails of golang/codeaction.go (messy diff):\n- don't separate \"typed\" from \"syntax only\" operations;\n in practice we always need types.\n- enabled (func) replaces want (map). It is computed\n in server.CodeAction and plumbed down.\n- the \"add\" helper wraps a Command in a CodeAction\n and adds it to the result.\n\nAlso:\n- use camelCase names, following LSP's source.organizeImports.\n- document the specific kinds in the user manual\n and add a release note.\n- remove the CodeAction title regexp parameter from\n @codeaction{,err} marker tests since the kind is\n now sufficiently expressive.\n\nFixes golang/go#40438\nUpdates golang/go#68791\nUpdates golang/go#68783\n\nChange-Id: I1898f79d8af441a0376ad5067d05e0621840d987\nReviewed-on: https://go-review.googlesource.com/c/tools/+/604818\nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/settings: use CodeActionKind hierarchy"}},{"before":"4e8d5c8a99f2f6196230b60da2be0578dbe8fcb1","after":"15b8886a84d5cf396f39e693ae05c4f1f87a1a9e","ref":"refs/heads/master","pushedAt":"2024-09-12T14:40:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"SignatureHelp: report signature of Ident if no enclosing CallExpr\n\nCurrently, SignatureHelp reports information only about an\nenclosing call expression. But it would be useful to show\nsignature information after entering the name of a function\nsuch as \"f\" or \"fmt.Println\", without call parens.\n\nSo, if there is no enclosing call, this change reports the\nsignature of the selected identifier if it is callable.\n\nFixes golang/go#68922\n\nChange-Id: Ibb0700e354c5d6e5937fc7f7b5db65e9d96574bb\nGitHub-Last-Rev: 5e7965edd342a450fd486ccd1fb7149ad20a2733\nGitHub-Pull-Request: golang/tools#510\nReviewed-on: https://go-review.googlesource.com/c/tools/+/605983\nReviewed-by: Alan Donovan \nReviewed-by: Robert Findley \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"SignatureHelp: report signature of Ident if no enclosing CallExpr"}},{"before":"6a387a400b7de86c9e97f1e0432973cdaa32c2ac","after":"4e8d5c8a99f2f6196230b60da2be0578dbe8fcb1","ref":"refs/heads/master","pushedAt":"2024-09-12T14:25:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: bump gofumpt to 0.7.0\n\nRelease notes: https://github.com/mvdan/gofumpt/releases/tag/v0.7.0\n\nNote gofumpt now uses go/version to parse version string, so\nfixLangVersion is no longer needed, but \"go\" prefix is a must.\n\nChange-Id: I8b8e0eb3f0268cddf31ef2fcee90566a17a065ee\nReviewed-on: https://go-review.googlesource.com/c/tools/+/609655\nReviewed-by: Robert Findley \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls: bump gofumpt to 0.7.0"}},{"before":"42a6477e4efe48405882cc5fd5bbe17b77d07b5e","after":"6a387a400b7de86c9e97f1e0432973cdaa32c2ac","ref":"refs/heads/master","pushedAt":"2024-09-11T23:18:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: require 1.23 for TestCycles\n\nTestCycles requires internal/trace/testtrace which was added in 1.23.\n\nFixes golang/go#69387\nFixes golang/go#69408\n\nChange-Id: Iaa6b24a94216e7f2d9f7239b131e4a7e9ef9210e\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612399\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Tim King ","shortMessageHtmlLink":"go/ssa: require 1.23 for TestCycles"}},{"before":"515711824d76668446153a24ead0753c9879ed26","after":"42a6477e4efe48405882cc5fd5bbe17b77d07b5e","ref":"refs/heads/master","pushedAt":"2024-09-11T22:28:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: disable TestTypeparamTest/chan.go on wasm\n\nAlso enables TestTypeparamTest/issue58513.go, which was\ndisabled for ssa/interp.\n\nFixes golang/go#64726\n\nChange-Id: I7966fd09e6ec8de662a99f21086f6a5c34d86ab9\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612398\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ssa: disable TestTypeparamTest/chan.go on wasm"}},{"before":"94ac686dafcbb8e58ccf13f5326bb7b4153fe867","after":"515711824d76668446153a24ead0753c9879ed26","ref":"refs/heads/master","pushedAt":"2024-09-11T21:25:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/lsp/source: put testing.T/B first when extracting\n\nPut the testing.T/B second when extracting functions/methods.\nIt's next after context.Context.\n\nFixes golang/go#69341\n\nChange-Id: Idcfc0e09e4174646a3f136dcc5badfda4af9938e\nGitHub-Last-Rev: 99de9722e6856e13dc2bc4d069cee149c62e3631\nGitHub-Pull-Request: golang/tools#517\nReviewed-on: https://go-review.googlesource.com/c/tools/+/610976\nAuto-Submit: Robert Findley \nReviewed-by: Tim King \nLUCI-TryBot-Result: Go LUCI \nRun-TryBot: Tim King \nReviewed-by: Robert Findley \nAuto-Submit: Tim King \nTryBot-Result: Gopher Robot ","shortMessageHtmlLink":"gopls/internal/lsp/source: put testing.T/B first when extracting"}},{"before":"288437536fb16daa8736da03ddd11eadfc571dc9","after":"94ac686dafcbb8e58ccf13f5326bb7b4153fe867","ref":"refs/heads/master","pushedAt":"2024-09-11T21:05:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: pop targets stack on range-over-func\n\nPop Function.targets when building a call to a range-over-func yield function and when building the yield function.\n\nAlso adds sanity checks to ensure all function transient fields are cleared.\n\nFixes golang/go#69298\n\nChange-Id: I38b80ce8939cf2cd6cfd0ce0c119d75356d80ebf\nGitHub-Last-Rev: 8c45b9c36e370bc74bdf765b0aa37b743735db8e\nGitHub-Pull-Request: golang/tools#516\nReviewed-on: https://go-review.googlesource.com/c/tools/+/611055\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"go/ssa: pop targets stack on range-over-func"}},{"before":"b0f680ccb8947d4e0d40e324862ccbc683afaa20","after":"288437536fb16daa8736da03ddd11eadfc571dc9","ref":"refs/heads/master","pushedAt":"2024-09-11T20:58:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: Definitions: support renaming imports in doc links\n\nThis CL adds support for jumping to the definition of a doc link when\nthe import is renamed. Before, the doc link had to use the local\n(renamed) name, which is unnatural; now, it can use either the local\nname or the package's declared name.\n\n+ test\n\nUpdates golang/go#61677\n\nChange-Id: Ibbe18ab1527800c41900d42781677ad892b55cd4\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612045\nAuto-Submit: Alan Donovan \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/golang: Definitions: support renaming imports in doc l…"}},{"before":"b7af269531b4c4f7403fac16567925a0a2e1557b","after":"b0f680ccb8947d4e0d40e324862ccbc683afaa20","ref":"refs/heads/master","pushedAt":"2024-09-10T18:45:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: reenable TestStdlib\n\nIt wasn't broken on the builder--only with my local go toolchain.\n(There was some cgo-related problem with cmd/cgo/internal/test.)\nAt least that explains why we didn't notice the failures...\n\nThis CL also adds a missing error check that made the real cause\nof the problem hard to spot, and improves some comments and\nassertions.\n\nFixes golang/go#69287\n\nChange-Id: Iccbe2a72770499749ca780f78e2a61d5576f613b\nReviewed-on: https://go-review.googlesource.com/c/tools/+/612044\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"go/ssa: reenable TestStdlib"}},{"before":"fd7ab2daaaf4b704fd477436b9c6f7732bbabbed","after":"b7af269531b4c4f7403fac16567925a0a2e1557b","ref":"refs/heads/master","pushedAt":"2024-09-10T17:05:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ssa: improve sanity checking\n\n* sanity check transient fields\n* sanity check signature recv/params and the Params field\n* fix error checking 'err != err'\n\nChange-Id: I5a9df1d59176c8ddc5521849490518eb277a51fa\nGitHub-Last-Rev: c96247666108a5350edc8275a75e9c8375b31fb2\nGitHub-Pull-Request: golang/tools#514\nReviewed-on: https://go-review.googlesource.com/c/tools/+/610059\nReviewed-by: Tim King \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ssa: improve sanity checking"}},{"before":"dc4c52551c5c99d3ee45dacb91f903c6affd8013","after":"fd7ab2daaaf4b704fd477436b9c6f7732bbabbed","ref":"refs/heads/master","pushedAt":"2024-09-10T16:53:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/server: fix build following semantic merge conflict\n\nFix the gopls build, which was broken by a semantic merge conflict with\nCL 548675 (the slices package was made obsolete after updating to Go\n1.23.1).\n\nChange-Id: Ic8b82598b66c560298dd9b8f968a1087e12320f3\nReviewed-on: https://go-review.googlesource.com/c/tools/+/611839\nReviewed-by: Hongxiang Jiang \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Tim King ","shortMessageHtmlLink":"gopls/internal/server: fix build following semantic merge conflict"}},{"before":"8ba91691647756357cce2b7fa3dcf4051528cfc4","after":"dc4c52551c5c99d3ee45dacb91f903c6affd8013","ref":"refs/heads/master","pushedAt":"2024-09-10T14:00:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal: test discovery\n\nImplements test discovery. Tests are discovered as part of the type\nchecking process, at the same time as method sets and xrefs, and cached.\nDoes not implement the Modules command.\n\nAdds static detection of simple subtests. This provides a framework for\nstatic analysis of subtests but intentionally does not support more than\nthe most trivial case in order to minimize the complexity of this CL.\n\nFixes golang/go#59445. Updates golang/go#59445, golang/vscode-go#1602,\ngolang/vscode-go#2445.\n\nChange-Id: Ief497977da09a1e07831e6c5f3b7d28d6874fd9f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/548675\nReviewed-by: Alan Donovan \nReviewed-by: Robert Findley \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal: test discovery"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOFQyMDoxODo0Ny4wMDAwMDBazwAAAAS6INEH","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOFQyMDoxODo0Ny4wMDAwMDBazwAAAAS6INEH","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMFQxNDowMDoxMy4wMDAwMDBazwAAAASyIfoJ"}},"title":"Activity · golang/tools"}