txtar: return the result of slices.Clone

Stavrospanakakis · Stavrospanakakis · commit 468e40586d31 · 2024-09-17T18:07:22.000+03:00
diff --git a/txtar/fs.go b/txtar/fs.go
@@ -153,8 +153,7 @@ func (fsys *filesystem) ReadFile(name string) ([]byte, error) {
 		return nil, err
 	}
 	if file, ok := file.(*openFile); ok {
-		cp := slices.Clone(file.data)
-		return cp, err
+		return slices.Clone(file.data), nil
 	}
 	return nil, &fs.PathError{Op: "read", Path: name, Err: fs.ErrInvalid}
 }

Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,7 @@ func (fsys *filesystem) ReadFile(name string) ([]byte, error) {`
`153`	`153`	`return nil, err`
`154`	`154`	`}`
`155`	`155`	`if file, ok := file.(*openFile); ok {`
`156`		`- cp := slices.Clone(file.data)`
`157`		`- return cp, err`
	`156`	`+ return slices.Clone(file.data), nil`
`158`	`157`	`}`
`159`	`158`	`return nil, &fs.PathError{Op: "read", Path: name, Err: fs.ErrInvalid}`
`160`	`159`	`}`