Skip to content

Commit

Permalink
gopls/internal/regtest/misc: update some unilaterally skipped tests
Browse files Browse the repository at this point in the history
Remove skips for two tests related to line directives (now fixed), and
delete a test related to the old parse cache, which no longer exists.

Updates golang/go#53878

Change-Id: I15b1e5d72f5ccc8c094eaa43e73a9bcc1f75c031
Reviewed-on: https://go-review.googlesource.com/c/tools/+/496882
Reviewed-by: Peter Weinberger <pjw@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
  • Loading branch information
findleyr committed May 22, 2023
1 parent 5ff5cbb commit a12ee94
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 91 deletions.
2 changes: 0 additions & 2 deletions gopls/internal/regtest/misc/failures_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import (
// that includes a line directive, which makes no difference since
// gopls ignores line directives.
func TestHoverFailure(t *testing.T) {
t.Skip("line directives //line ")
const mod = `
-- go.mod --
module mod.com
Expand Down Expand Up @@ -48,7 +47,6 @@ func main() {
// This test demonstrates a case where gopls is not at all confused by
// line directives, because it completely ignores them.
func TestFailingDiagnosticClearingOnEdit(t *testing.T) {
t.Skip("line directives //line ")
// badPackageDup contains a duplicate definition of the 'a' const.
// This is a minor variant of TestDiagnosticClearingOnEdit from
// diagnostics_test.go, with a line directive, which makes no difference.
Expand Down
89 changes: 0 additions & 89 deletions gopls/internal/regtest/misc/leak_test.go

This file was deleted.

0 comments on commit a12ee94

Please sign in to comment.