Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snippets: add snippet for type function declaration #1002

Closed
wants to merge 1 commit into from
Closed

snippets: add snippet for type function declaration #1002

wants to merge 1 commit into from

Conversation

programmer04
Copy link
Contributor

@programmer04 programmer04 commented Dec 5, 2020 •
edited
Loading

Add snippet with name tyf for type function declaration:

type name func() // snippet to fill
type Example func(string, int) error // example of filled snippet

Rationale - they are already:

  • tyi - snippet for a type interface
  • tys - snippet for a struct declaration

the only one missing is a snippet for type function declaration. It is quite common in Go to declare and use function types, so this new snippet makes a programmer's life easier

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 5, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 786fc72) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/275572 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/275572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Run-TryBot+1 Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/275572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/0084bffe-3033-4696-9309-9766e10d33ee

Please don’t reply on this GitHub thread. Visit golang.org/cl/275572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 4: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/0084bffe-3033-4696-9309-9766e10d33ee

Please don’t reply on this GitHub thread. Visit golang.org/cl/275572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/275572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 4: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/275572.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 11, 2020
@programmer04 @hyangah
snippets: add snippet for type function declaration
a1ed38c 
Add snippet with name `tyf` for type function declaration:
```
type name func() // snippet to fill
type Example func(string, int) error // example of filled snippet
```
Rationale - they are already:
- `tyi` - snippet for a type interface
- `tys` - snippet for a struct declaration

the only one missing is a snippet for type function declaration. It is quite common in Go to declare and use function types, so this new snippet makes a programmer's life easier

Change-Id: Ib04cb122bdf25b6983b7c704e88ca56fc7df77e5
GitHub-Last-Rev: 786fc72
GitHub-Pull-Request: #1002
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/275572
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/275572 has been merged.

@gopherbot gopherbot closed this Dec 11, 2020
@programmer04 programmer04 deleted the new-snippet-tyf branch December 11, 2020 22:20
@hyangah hyangah added this to the v0.20.0 milestone Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@programmer04 @gopherbot @hyangah