Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delve's maxGoroutines should be configurable via go.delveConfig #2041

Open
shaunco opened this issue Jan 31, 2022 · 2 comments
Open

Delve's maxGoroutines should be configurable via go.delveConfig #2041

shaunco opened this issue Jan 31, 2022 · 2 comments
Labels
debug/callstack callstack handling related debug issues Debug Issues related to the debugging functionality of the extension. FeatureRequest

Comments

@shaunco
Copy link

shaunco commented Jan 31, 2022

Is your feature request related to a problem? Please describe.
When debugging issues that involve large numbers of goroutines, VSCode will output Too many goroutines, only loaded 1024. It would be very nice to be able to configure this max limit.

Describe the solution you'd like
When vscode-go calls Debugger.Goroutines(start, count), either count (maxGoroutines) should be configurable in go.delveConfig or there should be a "Load More..." button at the bottom of the list of 1024 goroutines that will load another 1024.

Describe alternatives you've considered
The only alternative is to use dlv on the CLI.

@gopherbot gopherbot added this to the Untriaged milestone Jan 31, 2022
@hyangah
Copy link
Contributor

hyangah commented Jan 31, 2022

VS Code team is investigating a better support in UI and the underlying debug protocol
microsoft/vscode#116109

@suzmue @polinasok what do you think about adding maxGoroutines to the config list that's configurable dynamically? I am personally skeptical about dumping a large number of goroutines without proper support from VS Code UI and DAP protocol support. (See #129 to see what kind of problems users would face) But if VS Code team's support is delayed, we may consider adding this for users to try at their own risk.

@hyangah hyangah added the Debug Issues related to the debugging functionality of the extension. label Jan 31, 2022
@hyangah hyangah modified the milestones: Untriaged, Unplanned Jan 31, 2022
@polinasok polinasok added the debug/callstack callstack handling related debug issues label Apr 8, 2022
@polinasok
Copy link
Contributor

There is no paging support in the underlying protocol. We filed an issue in Nov 2020. That triggered some efforts to investigate alternative protocol & related vscode UI options.

It might not be a bad idea too add maxGoroutines to launch.json and to dlv config (via DEBUG CONSOLE), but with a warning that increasing the limit can freeze the editor (#129).

@shaunco Depending on your needs, it might be more beneficial to try filtering instead of scrolling over pages and pages of goroutines - please try dlv config goroutineFilters via DEBUG CONSOLE with filters referenced here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug/callstack callstack handling related debug issues Debug Issues related to the debugging functionality of the extension. FeatureRequest
Projects
None yet
Development

No branches or pull requests

4 participants