-
Notifications
You must be signed in to change notification settings - Fork 795
Upgrade direct dependencies in combination with the go tool directive: #3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi hu3bi, Thanks for reporting this issue. The code lens is reported from gopls, see documentation. Behind the scene, its running I'm not expert of go binary, maybe @samthanawalla can share thoughts or concerns see if this is ok to change the implementations. |
cc: @matloob |
Based on the discussion, I think we can do a go mod tidy after upgrade dependency. Or consider running |
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
I should remove the waiting for info tag. This is a FR. |
Is your feature request related to a problem? Please describe.
When clicking "Upgrade direct dependencies", VS Code pulls in several unnecessary (tool) dependencies, which are removed after running go mod tidy. This behavior may be confusing, especially for new Go developers.
Describe the solution you'd like
I would prefer the same outcome as running
go get -u all
Or vscode could just keep the behavior as it is and run go mod tidy afterward
Additional context
golang/go#71663
The text was updated successfully, but these errors were encountered: