Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippets: add snippet for TestMain #629

Closed
wants to merge 1 commit into from
Closed

Conversation

pofl
Copy link
Contributor

@pofl pofl commented Sep 10, 2020

This is a natural extension of the existing test/benchmark functions snippets (tf, bf).

Update #160

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Sep 10, 2020
@pofl
Copy link
Contributor Author

pofl commented Sep 10, 2020

I don't care about all that bureaucracy. If you want, anyone reading this can take my contribution and resubmit it as theirs.

@pofl
Copy link
Contributor Author

pofl commented Sep 12, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Sep 12, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 3c1f73d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/254497 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/254497.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/254497.
After addressing review feedback, remember to publish your drafts!

@pofl
Copy link
Contributor Author

pofl commented Nov 2, 2020

I understand that you want to move snippets to gopls. But until you tackle that plan, would you maybe accept this PR? The snippet can later still be migrated. If you prefer, I could also change the snippet from triggering on tm to triggering on testmain so that it is suggested in less inappropriate cases.

@hyangah hyangah changed the title Add snippet for TestMain snippets: add snippet for TestMain Nov 19, 2020
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/254497.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 19, 2020
This is a natural extension of the existing test/benchmark functions snippets (tf, bf).

Update #160

Change-Id: I9e787dea7fbcc063b1d1a13dffee6b09905120fe
GitHub-Last-Rev: 3c1f73d
GitHub-Pull-Request: #629
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254497
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 2: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/254497.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/254497 has been merged.

@gopherbot gopherbot closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants