Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: send back an error response if variable loading fails #840

Closed
polinasok opened this issue Oct 26, 2020 · 2 comments
Closed

debug: send back an error response if variable loading fails #840

polinasok opened this issue Oct 26, 2020 · 2 comments
Assignees
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge

Comments

@polinasok
Copy link
Contributor

polinasok commented Oct 26, 2020

Variable request handler should detect if variable auto-loading via expression evaluation in loadChildren (e.g. like in #135, #1052) failed and return an error response in that case. Currently the error is only logged to the DEBUG CONSOLE and is easy to miss, especially if verbose logging is on. If we return the error via the response, it will be displayed in the VARIABLES pane, and the option to expand for more children (which would only return more errors) would be disabled.

@polinasok polinasok added Debug Issues related to the debugging functionality of the extension. DelveDAP labels Oct 26, 2020
@polinasok polinasok changed the title debug: We should send back an error response if variable loading fails debug: send back an error response if variable loading fails Oct 27, 2020
@polinasok
Copy link
Contributor Author

polinasok commented Apr 5, 2021

dlv-dap is taking a different approach here for reporting errors:
image
Instead of returning a failed request, it prints the type of the variable along with the error and disables loading of any children.

@polinasok
Copy link
Contributor Author

For types where we do not have auto-loading yet, we report things like so:
image
image

@golang golang locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants