Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: add missing transform variants for go.addTags #936

Closed
wants to merge 1 commit into from

Conversation

skaldesh
Copy link
Contributor

This simply allows in the settings.json or UI to use the missing 'lispcase', 'pascalcase' and 'keep'
transform options for the go.addTags command.

fixes #906

This simply allows in the settings.json or UI to use the missing 'lispcase', 'pascalcase' and 'keep'
transform options for the go.addTags command.

fixes golang#906
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 18, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: e181a58) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/271357 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/271357.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/791ebf43-3d33-4743-b653-d670c0058141


Please don’t reply on this GitHub thread. Visit golang.org/cl/271357.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/791ebf43-3d33-4743-b653-d670c0058141


Please don’t reply on this GitHub thread. Visit golang.org/cl/271357.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/271357.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 19, 2020
This simply allows in the settings.json or UI to use the missing 'lispcase', 'pascalcase' and 'keep'
transform options for the go.addTags command.

fixes #906

Change-Id: Ic1ef1fd6e9df755d048424275e75033914c91060
GitHub-Last-Rev: e181a58
GitHub-Pull-Request: #936
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/271357
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/271357 has been merged.

@gopherbot gopherbot closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Struct Tags: More transform variants
2 participants