x/vulndb: potential Go vuln in github.com/authzed/spicedb: CVE-2023-29193

[GoVulnBot]

CVE-2023-29193 references github.com/authzed/spicedb, which may be a Go module.

Description:
SpiceDB is an open source, Google Zanzibar-inspired, database system for creating and managing security-critical application permissions. The spicedb serve command contains a flag named --grpc-preshared-key which is used to protect the gRPC API from being accessed by unauthorized requests. The values of this flag are to be considered sensitive, secret data. The /debug/pprof/cmdline endpoint served by the metrics service (defaulting running on port 9090) reveals the command-line flags provided for debugging purposes. If a password is set via the --grpc-preshared-key then the key is revealed by this endpoint along with any other flags provided to the SpiceDB binary. This issue has been fixed in version 1.19.1.

Impact

All deployments abiding by the recommended best practices for production usage are NOT affected:

• Authzed's SpiceDB Serverless
• Authzed's SpiceDB Dedicated
• SpiceDB Operator

Users configuring SpiceDB via environment variables are NOT affected.

Users MAY be affected if they expose their metrics port to an untrusted network and are configuring --grpc-preshared-key via command-line flag.

Patches

TODO

Workarounds

To workaround this issue you can do one of the following:

• Configure the preshared key via an environment variable (e.g. SPICEDB_GRPC_PRESHARED_KEY=yoursecret spicedb serve)
• Reconfigure the --metrics-addr flag to bind to a trusted network (e.g. --metrics-addr=localhost:9090)
• Disable the metrics service via the flag (e.g. --metrics-enabled=false)
• Adopt one of the recommended deployment models: Authzed's managed services or the SpiceDB Operator

References

• GitHub Security Advisory issued for SpiceDB
• Go issue #22085 for documenting the risks of exposing pprof to the internet
• Go issue #42834 discusses preventing pprof registration to the default serve mux
• semgrep rule go.lang.security.audit.net.pprof.pprof-debug-exposure checks for a variation of this issue

Credit

We'd like to thank Amit Laish, a security researcher at GE Vernova for responsibly disclosing this vulnerability.

References:

• NIST: https://nvd.nist.gov/vuln/detail/CVE-2023-29193
• JSON: https://github.com/CVEProject/cvelist/tree/3f02c95115ca6b45296a9bffce15cbaa6768b5b8/2023/29xxx/CVE-2023-29193.json
• advisory: GHSA-cjr9-mr35-7xh6
• fix: authzed/spicedb@9bbd7d7
• web: https://github.com/authzed/spicedb/releases/tag/v1.19.1
• Imported by: https://pkg.go.dev/github.com/authzed/spicedb?tab=importedby

Cross references:

• Module github.com/authzed/spicedb appears in issue x/vulndb: potential Go vuln in github.com/authzed/spicedb: CVE-2022-21646 #295 EFFECTIVELY_PRIVATE

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: github.com/authzed/spicedb
    packages:
      - package: spicedb
description: |+
    SpiceDB is an open source, Google Zanzibar-inspired, database system for creating and managing security-critical application permissions. The `spicedb serve` command contains a flag named `--grpc-preshared-key` which is used to protect the gRPC API from being accessed by unauthorized requests. The values of this flag are to be considered sensitive, secret data. The `/debug/pprof/cmdline` endpoint served by the metrics service (defaulting running on port `9090`) reveals the command-line flags provided for debugging purposes. If a password is set via the `--grpc-preshared-key` then the key is revealed by this endpoint along with any other flags provided to the SpiceDB binary. This issue has been fixed in version 1.19.1.

    ### Impact

    All deployments abiding by the recommended best practices for production usage are **NOT affected**:
    - Authzed's SpiceDB Serverless
    - Authzed's SpiceDB Dedicated
    - SpiceDB Operator

    Users configuring SpiceDB via environment variables are **NOT affected**.

    Users **MAY be affected** if they expose their metrics port to an untrusted network and are configuring `--grpc-preshared-key` via command-line flag.

    ### Patches

    TODO

    ### Workarounds

    To workaround this issue you can do one of the following:

    - Configure the preshared key via an environment variable (e.g. `SPICEDB_GRPC_PRESHARED_KEY=yoursecret spicedb serve`)
    - Reconfigure the `--metrics-addr` flag to bind to a trusted network (e.g. `--metrics-addr=localhost:9090`)
    - Disable the metrics service via the flag (e.g. `--metrics-enabled=false`)
    - Adopt one of the recommended deployment models: [Authzed's managed services](https://authzed.com/pricing) or the [SpiceDB Operator](https://github.com/authzed/spicedb-operator)

    ### References

    - [GitHub Security Advisory issued for SpiceDB](https://github.com/authzed/spicedb/security/advisories/GHSA-cjr9-mr35-7xh6)
    - [Go issue #22085](https://github.com/golang/go/issues/22085) for documenting the risks of exposing pprof to the internet
    - [Go issue #42834](https://github.com/golang/go/issues/42834) discusses preventing pprof registration to the default serve mux
    - [semgrep rule go.lang.security.audit.net.pprof.pprof-debug-exposure](https://semgrep.dev/r?q=go.lang.security.audit.net.pprof) checks for a variation of this issue

    ### Credit

    We'd like to thank Amit Laish, a security researcher at GE Vernova for responsibly disclosing this vulnerability.

cves:
  - CVE-2023-29193
references:
  - advisory: https://github.com/authzed/spicedb/security/advisories/GHSA-cjr9-mr35-7xh6
  - fix: https://github.com/authzed/spicedb/commit/9bbd7d76b6eaba33fe0236014f9b175d21232999
  - web: https://github.com/authzed/spicedb/releases/tag/v1.19.1

[timothy-king]

Duplicate of #1723