Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to make suggested changes on a PR #35

Closed
szunami opened this issue Jul 10, 2020 · 4 comments
Closed

Ability to make suggested changes on a PR #35

szunami opened this issue Jul 10, 2020 · 4 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@szunami
Copy link

szunami commented Jul 10, 2020

Really appreciating this action, and it's ability to annotate PRs.

For many of the lint / vet rules, I think there are somewhat straightforward fixes. It would be awesome if this action could make suggested changes when possible (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request). Is this at all feasible?

@sayboras
Copy link
Member

Once #5 is tackled, we can do this one. As suggesttion changes based on my understanding is just comment with suggestion block

@sayboras sayboras added the enhancement New feature or request label Jul 10, 2020
@sayboras
Copy link
Member

Just a note on this that not all linters are giving suggestion to correct error.

@szunami
Copy link
Author

szunami commented Jul 12, 2020

That makes sense.

I think the suggestion UX is such a paradigm shift that could really improve adoption of linters, and would love to see those that don't currently support it think about what they could do (understanding that there are technical limitations). Thanks for the response, I might have some time to contribute in the near future. Please keep me posted!

@ldez ldez added the duplicate This issue or pull request already exists label May 9, 2024
@ldez
Copy link
Member

ldez commented May 9, 2024

Kind of a duplicate of #5

The review comments are just comments with position.

@ldez ldez closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
3 participants