Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building golangci-lint from source #530

Closed
SuperSandro2000 opened this issue Aug 3, 2022 · 2 comments
Closed

Allow building golangci-lint from source #530

SuperSandro2000 opened this issue Aug 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@SuperSandro2000
Copy link

To solve issues like #442 (comment) it would be cool if instead of downloading the precompiled binary you could either set a flag that golangci-lint is build from source or the user needs to download and install it in a previous step and the action just expects it to be in $PATH.

@shahzadlone
Copy link

Sounds like a good idea! I found this is what was causing our builds to fail as we are on 1.18 and the precompiled 1.48 golangci-lint would keep using 1.19 golang rules, when the one built from source was working fine.

@ldez ldez added the enhancement New feature or request label Aug 7, 2022
@ldez
Copy link
Member

ldez commented Aug 7, 2022

Close in favor of #540

@ldez ldez closed this as completed Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants