chore: remove deprecated errcheck tests

Author: ldez

pkg/golinters/errcheck/errcheck.go

@@ -111,35 +111,6 @@ func runErrCheck(lintCtx *linter.Context, pass *analysis.Pass, checker *errcheck
 	return issues
 }
 
-// parseIgnoreConfig was taken from errcheck in order to keep the API identical.
-// https://github.com/kisielk/errcheck/blob/1787c4bee836470bf45018cfbc783650db3c6501/main.go#L25-L60
-func parseIgnoreConfig(s string) (map[string]*regexp.Regexp, error) {
-	if s == "" {
-		return nil, nil
-	}
-
-	cfg := map[string]*regexp.Regexp{}
-
-	for _, pair := range strings.Split(s, ",") {
-		colonIndex := strings.Index(pair, ":")
-		var pkg, re string
-		if colonIndex == -1 {
-			pkg = ""
-			re = pair
-		} else {
-			pkg = pair[:colonIndex]
-			re = pair[colonIndex+1:]
-		}
-		regex, err := regexp.Compile(re)
-		if err != nil {
-			return nil, err
-		}
-		cfg[pkg] = regex
-	}
-
-	return cfg, nil
-}
-
 func getChecker(errCfg *config.ErrcheckSettings) (*errcheck.Checker, error) {
 	ignoreConfig, err := parseIgnoreConfig(errCfg.Ignore)
 	if err != nil {
@@ -176,29 +147,62 @@ func getChecker(errCfg *config.ErrcheckSettings) (*errcheck.Checker, error) {
 	return &checker, nil
 }
 
-func getFirstPathArg() string {
-	args := os.Args
+// parseIgnoreConfig was taken from errcheck in order to keep the API identical.
+// https://github.com/kisielk/errcheck/blob/1787c4bee836470bf45018cfbc783650db3c6501/main.go#L25-L60
+func parseIgnoreConfig(s string) (map[string]*regexp.Regexp, error) {
+	if s == "" {
+		return nil, nil
+	}
 
-	// skip all args ([golangci-lint, run/linters]) before files/dirs list
-	for len(args) != 0 {
-		if args[0] == "run" {
-			args = args[1:]
-			break
-		}
+	cfg := map[string]*regexp.Regexp{}
 
-		args = args[1:]
+	for _, pair := range strings.Split(s, ",") {
+		colonIndex := strings.Index(pair, ":")
+		var pkg, re string
+		if colonIndex == -1 {
+			pkg = ""
+			re = pair
+		} else {
+			pkg = pair[:colonIndex]
+			re = pair[colonIndex+1:]
+		}
+		regex, err := regexp.Compile(re)
+		if err != nil {
+			return nil, err
+		}
+		cfg[pkg] = regex
 	}
 
-	// find first file/dir arg
-	firstArg := "./..."
-	for _, arg := range args {
-		if !strings.HasPrefix(arg, "-") {
-			firstArg = arg
+	return cfg, nil
+}
+
+func readExcludeFile(name string) ([]string, error) {
+	var err error
+	var fh *os.File
+
+	for _, path := range setupConfigFileSearch(name) {
+		if fh, err = os.Open(path); err == nil {
 			break
 		}
 	}
 
-	return firstArg
+	if fh == nil {
+		return nil, fmt.Errorf("failed reading exclude file: %s: %w", name, err)
+	}
+	defer func() { _ = fh.Close() }()
+
+	scanner := bufio.NewScanner(fh)
+
+	var excludes []string
+	for scanner.Scan() {
+		excludes = append(excludes, scanner.Text())
+	}
+
+	if err := scanner.Err(); err != nil {
+		return nil, fmt.Errorf("failed scanning file: %s: %w", name, err)
+	}
+
+	return excludes, nil
 }
 
 func setupConfigFileSearch(name string) []string {
@@ -241,31 +245,27 @@ func setupConfigFileSearch(name string) []string {
 	return configSearchPaths
 }
 
-func readExcludeFile(name string) ([]string, error) {
-	var err error
-	var fh *os.File
+func getFirstPathArg() string {
+	args := os.Args
 
-	for _, path := range setupConfigFileSearch(name) {
-		if fh, err = os.Open(path); err == nil {
+	// skip all args ([golangci-lint, run/linters]) before files/dirs list
+	for len(args) != 0 {
+		if args[0] == "run" {
+			args = args[1:]
 			break
 		}
-	}
-
-	if fh == nil {
-		return nil, fmt.Errorf("failed reading exclude file: %s: %w", name, err)
-	}
-	defer func() { _ = fh.Close() }()
-
-	scanner := bufio.NewScanner(fh)
 
-	var excludes []string
-	for scanner.Scan() {
-		excludes = append(excludes, scanner.Text())
+		args = args[1:]
 	}
 
-	if err := scanner.Err(); err != nil {
-		return nil, fmt.Errorf("failed scanning file: %s: %w", name, err)
+	// find first file/dir arg
+	firstArg := "./..."
+	for _, arg := range args {
+		if !strings.HasPrefix(arg, "-") {
+			firstArg = arg
+			break
+		}
 	}
 
-	return excludes, nil
+	return firstArg
 }