dev: update global migration command

Author: ldez

pkg/commands/internal/migrate/migrate_linter_names.go

@@ -712,8 +712,9 @@ func allLinters() []LinterInfo {
 			Slow:    true,
 		},
 		{
-			Name:    "wsl",
-			Presets: []string{"style"},
+			Name:             "wsl_v5",
+			Presets:          []string{"style"},
+			AlternativeNames: []string{"wsl"}, // Fake alternative name.
 		},
 		{
 			Name:    "zerologlint",
@@ -937,6 +938,10 @@ func convertAlternativeNames(names []string) []string {
 		"megacheck": "staticcheck",
 		"vet":       "govet",
 		"vetshadow": "govet",
+
+		// Not an alternative name but a new linter major version,
+		// but it can be handled in the same way.
+		"wsl": "wsl_v5",
 	}
 
 	var results []string

pkg/commands/internal/migrate/migrate_linters_settings.go

@@ -4,6 +4,8 @@ import (
 	"slices"
 	"strings"
 
+	wslv5 "github.com/bombsimon/wsl/v5"
+
 	"github.com/golangci/golangci-lint/v2/pkg/commands/internal/migrate/ptr"
 	"github.com/golangci/golangci-lint/v2/pkg/commands/internal/migrate/versionone"
 	"github.com/golangci/golangci-lint/v2/pkg/commands/internal/migrate/versiontwo"
@@ -87,7 +89,7 @@ func toLinterSettings(old versionone.LintersSettings) versiontwo.LintersSettings
 		Varnamelen:      toVarnamelenSettings(old.Varnamelen),
 		Whitespace:      toWhitespaceSettings(old.Whitespace),
 		Wrapcheck:       toWrapcheckSettings(old.Wrapcheck),
-		WSL:             toWSLSettings(old.WSL),
+		WSLv5:           toWSLSettings(old.WSL),
 		Custom:          toCustom(old.Custom),
 	}
 }
@@ -998,22 +1000,46 @@ func toWrapcheckSettings(old versionone.WrapcheckSettings) versiontwo.WrapcheckS
 	}
 }
 
-func toWSLSettings(old versionone.WSLSettings) versiontwo.WSLv4Settings {
-	return versiontwo.WSLv4Settings{
-		StrictAppend:                     old.StrictAppend,
-		AllowAssignAndCallCuddle:         old.AllowAssignAndCallCuddle,
-		AllowAssignAndAnythingCuddle:     old.AllowAssignAndAnythingCuddle,
-		AllowMultiLineAssignCuddle:       old.AllowMultiLineAssignCuddle,
-		ForceCaseTrailingWhitespaceLimit: old.ForceCaseTrailingWhitespaceLimit,
-		AllowTrailingComment:             old.AllowTrailingComment,
-		AllowSeparatedLeadingComment:     old.AllowSeparatedLeadingComment,
-		AllowCuddleDeclaration:           old.AllowCuddleDeclaration,
-		AllowCuddleWithCalls:             old.AllowCuddleWithCalls,
-		AllowCuddleWithRHS:               old.AllowCuddleWithRHS,
-		ForceCuddleErrCheckAndAssign:     old.ForceCuddleErrCheckAndAssign,
-		ErrorVariableNames:               old.ErrorVariableNames,
-		ForceExclusiveShortDeclarations:  old.ForceExclusiveShortDeclarations,
+func toWSLSettings(old *versionone.WSLSettings) versiontwo.WSLv5Settings {
+	if old == nil {
+		return versiontwo.WSLv5Settings{}
+	}
+
+	cfg := versiontwo.WSLv5Settings{
+		AllowFirstInBlock: ptr.Pointer(true),
+		AllowWholeBlock:   ptr.Pointer(false),
+		BranchMaxLines:    ptr.Pointer(2),
+		CaseMaxLines:      old.ForceCaseTrailingWhitespaceLimit,
+	}
+
+	if !ptr.Deref(old.StrictAppend) {
+		cfg.Disable = append(cfg.Disable, wslv5.CheckAppend.String())
+	}
+
+	if ptr.Deref(old.AllowAssignAndAnythingCuddle) {
+		cfg.Disable = append(cfg.Disable, wslv5.CheckAssign.String())
+	}
+
+	if ptr.Deref(old.AllowCuddleDeclaration) {
+		cfg.Disable = append(cfg.Disable, wslv5.CheckDecl.String())
+	}
+
+	if ptr.Deref(old.ForceCuddleErrCheckAndAssign) {
+		cfg.Enable = append(cfg.Enable, wslv5.CheckErr.String())
+	}
+
+	if ptr.Deref(old.ForceExclusiveShortDeclarations) {
+		cfg.Enable = append(cfg.Enable, wslv5.CheckAssignExclusive.String())
 	}
+
+	if !ptr.Deref(old.AllowAssignAndCallCuddle) {
+		cfg.Enable = append(cfg.Enable, wslv5.CheckAssignExpr.String())
+	}
+
+	slices.Sort(cfg.Enable)
+	slices.Sort(cfg.Disable)
+
+	return cfg
 }
 
 func toCustom(old map[string]versionone.CustomLinterSettings) map[string]versiontwo.CustomLinterSettings {

pkg/commands/internal/migrate/testdata/yaml/linters-settings_goconst.golden.yml

@@ -2,14 +2,14 @@ version: "2"
 linters:
   settings:
     goconst:
-      ignore-strings: foo.+
       match-constant: false
       min-len: 2
       min-occurrences: 2
       numbers: true
       min: 2
       max: 2
       ignore-calls: false
+      ignore-strings: foo.+
   exclusions:
     rules:
       - linters:

pkg/commands/internal/migrate/testdata/yaml/linters-settings_nakedret_zero.golden.yml

@@ -1,5 +1,4 @@
 version: "2"
-
 linters:
   settings:
     nakedret:

pkg/commands/internal/migrate/testdata/yaml/linters-settings_wsl.golden.yml

@@ -1,22 +1,16 @@
 version: "2"
 linters:
   settings:
-    wsl:
-      strict-append: false
-      allow-assign-and-call: false
-      allow-assign-and-anything: true
-      allow-multiline-assign: false
-      force-case-trailing-whitespace: 1
-      allow-trailing-comment: true
-      allow-separated-leading-comment: true
-      allow-cuddle-declarations: true
-      allow-cuddle-with-calls:
-        - Foo
-        - Bar
-      allow-cuddle-with-rhs:
-        - Foo
-        - Bar
-      force-err-cuddling: true
-      error-variable-names:
-        - foo
-      force-short-decl-cuddling: true
+    wsl_v5:
+      allow-first-in-block: true
+      allow-whole-block: false
+      branch-max-lines: 2
+      case-max-lines: 1
+      enable:
+        - assign-exclusive
+        - assign-expr
+        - err
+      disable:
+        - append
+        - assign
+        - decl

pkg/commands/internal/migrate/testdata/yaml/linters_01.golden.yml

@@ -105,7 +105,7 @@ linters:
     - wastedassign
     - whitespace
     - wrapcheck
-    - wsl
+    - wsl_v5
     - zerologlint
 formatters:
   enable:

pkg/commands/internal/migrate/testdata/yaml/linters_02.golden.yml

@@ -105,5 +105,5 @@ linters:
     - wastedassign
     - whitespace
     - wrapcheck
-    - wsl
+    - wsl_v5
     - zerologlint

pkg/commands/internal/migrate/testdata/yaml/linters_03.golden.yml

@@ -20,7 +20,7 @@ linters:
     - wastedassign
     - whitespace
     - wrapcheck
-    - wsl
+    - wsl_v5
     - zerologlint
   disable:
     - asasalint

pkg/commands/internal/migrate/testdata/yaml/linters_06.golden.yml

@@ -22,7 +22,7 @@ linters:
     - wastedassign
     - whitespace
     - wrapcheck
-    - wsl
+    - wsl_v5
     - zerologlint
   disable:
     - asasalint

pkg/commands/internal/migrate/testdata/yaml/linters_07.golden.yml

@@ -103,7 +103,7 @@ linters:
     - wastedassign
     - whitespace
     - wrapcheck
-    - wsl
+    - wsl_v5
     - zerologlint
 formatters:
   enable: