feat: add durationcheck linter. (#1734)

Co-authored-by: Sergey Vilgelm <sergey.vilgelm@ibm.com>

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/ashanbrown/forbidigo v1.1.0
 	github.com/ashanbrown/makezero v0.0.0-20201205152432-7b7cdbb3025a
 	github.com/bombsimon/wsl/v3 v3.1.0
+	github.com/charithe/durationcheck v0.0.3
 	github.com/daixiang0/gci v0.2.8
 	github.com/denis-tingajkin/go-header v0.4.2
 	github.com/esimonov/ifshort v1.0.1

pkg/golinters/durationcheck.go

@@ -0,0 +1,15 @@
+package golinters
+
+import (
+	"github.com/charithe/durationcheck"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewDurationCheck() *goanalysis.Linter {
+	a := durationcheck.Analyzer
+
+	return goanalysis.NewLinter(a.Name, a.Doc, []*analysis.Analyzer{a}, nil).
+		WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/lint/lintersdb/manager.go

@@ -357,6 +357,10 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		linter.NewConfig(golinters.NewRevive(reviveCfg)).
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/mgechev/revive"),
+		linter.NewConfig(golinters.NewDurationCheck()).
+			WithPresets(linter.PresetBugs).
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/charithe/durationcheck"),
 
 		// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives
 		linter.NewConfig(golinters.NewNoLintLint()).

test/testdata/durationcheck.go

@@ -0,0 +1,9 @@
+//args: -Edurationcheck
+package testdata
+
+import "time"
+
+func waitFor(someDuration time.Duration) {
+	timeToWait := someDuration * time.Second // ERROR "Multiplication of durations: `someDuration \\* time.Second` "
+	time.Sleep(timeToWait)
+}