revive: add rule name in message. (#1772)

golangci · Feb 24, 2021 · b407bb8 · b407bb8
1 parent 42ff682
commit b407bb8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/golinters/revive.go b/pkg/golinters/revive.go
@@ -109,7 +109,7 @@ func NewRevive(cfg *config.ReviveSettings) *goanalysis.Linter {
 			for i := range results {
 				issues = append(issues, goanalysis.NewIssue(&result.Issue{
 					Severity: string(results[i].Severity),
-					Text:     fmt.Sprintf("%q", results[i].Failure.Failure),
+					Text:     fmt.Sprintf("%s: %s", results[i].RuleName, results[i].Failure.Failure),
 					Pos: token.Position{
 						Filename: results[i].Position.Start.Filename,
 						Line:     results[i].Position.Start.Line,

diff --git a/test/testdata/revive.go b/test/testdata/revive.go
@@ -7,7 +7,7 @@ import "time"
 func testRevive(t *time.Duration) error {
 	if t == nil {
 		return nil
-	} else { // ERROR "if block ends with a return statement, so drop this else and outdent its block"
+	} else { // ERROR "indent-error-flow: if block ends with a return statement, .*"
 		return nil
 	}
 }