fix: new rules

ldez · ldez · commit d6faeb8cc455 · 2021-10-12T12:09:55.000+02:00
diff --git a/pkg/golinters/goanalysis/runner_loadingpackage.go b/pkg/golinters/goanalysis/runner_loadingpackage.go
@@ -492,6 +492,6 @@ func sizeOfReflectValueTreeBytes(rv reflect.Value, visitedPtrs map[uintptr]struc
 	case reflect.Invalid:
 		return 0
 	default:
-		panic("unknown rv of type " + fmt.Sprint(rv))
+		panic("unknown rv of type " + rv.String())
 	}
 }
diff --git a/pkg/result/issue.go b/pkg/result/issue.go
@@ -92,7 +92,7 @@ func (i *Issue) Fingerprint() string {
 	}
 
 	hash := md5.New() //nolint:gosec
-	_, _ = hash.Write([]byte(fmt.Sprintf("%s%s%s", i.Pos.Filename, i.Text, firstLine)))
+	_, _ = fmt.Fprintf(hash, "%s%s%s", i.Pos.Filename, i.Text, firstLine)
 
 	return fmt.Sprintf("%X", hash.Sum(nil))
 }

Original file line number	Diff line number	Diff line change
`@@ -492,6 +492,6 @@ func sizeOfReflectValueTreeBytes(rv reflect.Value, visitedPtrs map[uintptr]struc`
`492`	`492`	`case reflect.Invalid:`
`493`	`493`	`return 0`
`494`	`494`	`default:`
`495`		`- panic("unknown rv of type " + fmt.Sprint(rv))`
	`495`	`+ panic("unknown rv of type " + rv.String())`
`496`	`496`	`}`
`497`	`497`	`}`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ func (i *Issue) Fingerprint() string {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`hash := md5.New() //nolint:gosec`
`95`		`- _, _ = hash.Write([]byte(fmt.Sprintf("%s%s%s", i.Pos.Filename, i.Text, firstLine)))`
	`95`	`+ _, _ = fmt.Fprintf(hash, "%s%s%s", i.Pos.Filename, i.Text, firstLine)`
`96`	`96`
`97`	`97`	`return fmt.Sprintf("%X", hash.Sum(nil))`
`98`	`98`	`}`