Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize path in exclude rules (OS path separator) #1398

Closed
shieldsjared opened this issue Sep 27, 2020 · 4 comments · Fixed by #2387
Closed

Normalize path in exclude rules (OS path separator) #1398

shieldsjared opened this issue Sep 27, 2020 · 4 comments · Fixed by #2387
Labels
enhancement New feature or improvement platform: windows Issue that is related to Windows

Comments

@shieldsjared
Copy link

shieldsjared commented Sep 27, 2020

Is your feature request related to a problem? Please describe.
When specifying path's w/in exclude rules, the path regex requires special attention for cross-platform path separators. Currently, you have to specify paths using syntax such as folder[/\\]file.go in order to gain cross-platform freedom. Some settings within the configuration appear to support automatic replacement of / with the operating system's default (e.g. on windows it becomes \).

Describe the solution you'd like
Identify all configuration's that involve a path (such as exclude-rules), and extend the functionality that currently replaces the path separator when executed on a windows platform while utilizing skip-files and skip-dir. Currently, I'm

Describe alternatives you've considered
No other alternatives considered. Honestly unsure of the implications of this request. Just throwing it out there for discussion :)

@shieldsjared shieldsjared added the enhancement New feature or improvement label Sep 27, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 27, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@frederikhors
Copy link

This is huge!

@ldez ldez added the platform: windows Issue that is related to Windows label Feb 21, 2021
@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Mar 30, 2022
@frederikhors
Copy link

Nope

@stale stale bot removed the stale No recent correspondence or work activity label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement platform: windows Issue that is related to Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants