scopelint reports false positives

[zlozano]

I recently pulled down the latest golangci-lint, and it is reporting false positives for scopelint on my table test. e.g.

   func TestSomething(t *testing.T) {
        tc := []struct {
		Name        string
		Expected  string
	}{
		{
			Name:       "foo",
			Expected: "bar",
		},
		{
			Name:       "fizz",
			Expected: "buzz",
		},
	}

	for _, tt := range tc {
		t.Run(tt.Name, func(t *testing.T) {
			result := thingUnderTest(...)
                         if result != tt.Expected {
                             t.Fatal("failed.")
                         }
		})
	}
   }

In this case since the testing closure is executed immediately in the same iteration, the mistake discussed here: https://github.com/golang/go/wiki/CommonMistakes is not relevant.

[powerman]

Another example of same issue:

for _, val := range vals {
    i := sort.Search(…, func(i int) bool { … val … })
}

Probably same happens with sort.Slice but I didn't tested this.

[jirfag]

hi!
does it reproduce with only scopelint? Or is it golangci-lint-only issue?

[powerman]

Yes, it does reproduce.

[cloudlena]

I just created an issue for scopelint. I think this one here can be closed because it's not a golangci-lint issue.

[jirfag]

Thank you