Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gci: Prefixes with capital letters are ignored #2985

Closed
4 tasks done
acabarbaye opened this issue Jul 18, 2022 · 1 comment · Fixed by #2992
Closed
4 tasks done

gci: Prefixes with capital letters are ignored #2985

acabarbaye opened this issue Jul 18, 2022 · 1 comment · Fixed by #2992
Labels
bug Something isn't working dependencies Relates to an upstream dependency

Comments

@acabarbaye
Copy link

acabarbaye commented Jul 18, 2022

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).
  • Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

The regression is with imports containing capital letters:
daixiang0/gci#79

Version of golangci-lint

1.4.7

Configuration file

run:
  timeout: 10m

  build-tags:
    - integration

linters:
  disable-all: true # Disable defaults, then enable the ones we want
  enable:
    - deadcode
    - errcheck
    - gosimple
    - govet
    - ineffassign
    - staticcheck
    - structcheck
    - typecheck
    - unused
    - varcheck
    - bodyclose
    - stylecheck
    - gosec
    - goimports
    - gci

linters-settings:
  goimports:
    local-prefixes: github.com/ARM-software
  gci:
    local-prefixes: github.com/ARM-software

Go environment

1.18

Verbose output of running

infinite loop

Code example or link to a public repository

see daixiang0/gci#79

@acabarbaye acabarbaye added the bug Something isn't working label Jul 18, 2022
@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Jul 18, 2022
@ldez ldez changed the title V1.4.7 - regression with gci version in use gci: Prefixes with capital letters are ignored Jul 18, 2022
@ldez ldez added dependencies Relates to an upstream dependency and removed linter: update Update the linter implementation inside golangci-lint labels Jul 18, 2022
@ldez
Copy link
Member

ldez commented Jul 18, 2022

Hello, I created a fix daixiang0/gci#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Relates to an upstream dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants