Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paralleltest missing ignoreloopVar option #4405

Closed
5 tasks done
sgerhardt opened this issue Feb 21, 2024 · 2 comments
Closed
5 tasks done

paralleltest missing ignoreloopVar option #4405

sgerhardt opened this issue Feb 21, 2024 · 2 comments
Labels
question Further information is requested

Comments

@sgerhardt
Copy link

Welcome

Description of the problem

It looks like I can't specify a way to ignore the loop vars, which was added in a version of paralleltest which appears to be in use with golangc-lint now https://github.com/kunwardeep/paralleltest/pull/35/files

Version of golangci-lint

$ golangci-lint --version
golangci-lint has version 1.56.2 built with go1.22.0 from 58a724a0 on 2024-02-15T18:01:51Z

Configuration

# paste configuration file or CLI flags here

Go environment

$ go version
# paste output here

go version go1.22.0 darwin/arm64

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
# paste output here

A minimal reproducible example or link to a public repository

// add your code here

Validation

  • Yes, I've included all information above (version, config, etc.).
@sgerhardt sgerhardt added the bug Something isn't working label Feb 21, 2024
Copy link

boring-cyborg bot commented Feb 21, 2024

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez added question Further information is requested and removed bug Something isn't working labels Feb 21, 2024
@ldez
Copy link
Member

ldez commented Feb 21, 2024

Hello,

This option is not exposed because, inside golangci-lint, the option is controlled by the Go version, this is not a user option.

if config.IsGoGreaterThanOrEqual(settings.Go, "1.22") {
d["ignoreloopVar"] = true
}

Otherwise, the current version of golangci-lint (v1.56.2) doesn't contain this update of paralleltest, it's will be a part of the next release (v1.57.0).

If you are looking for a workaround: #4273 (comment)

FYI, I'm the author of the PR kunwardeep/paralleltest#35

Related to #4394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants