Running linters through gometalinter and golangci give out different results

[iccengan]

1. Version:

golangci-lint --version
golangci-lint has version 1.17.1 built from 4ba2155 on 2019-06-10T09:06:49Z

2. no config file

go version go1.12.6 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/iccen/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/iccen/go_proj/test_proj"
GOPROXY=""
GORACE=""
GOROOT="/home/iccen/go"
GOTMPDIR=""
GOTOOLDIR="/home/iccen/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build132636320=/tmp/go-build -gno-record-gcc-switches"

Gometalinter command:
gometalinter ./... --enable-all --disable=govet --deadline=60m -j 2

Golangci-lint command:
golangci-lint run --enable-all --disable=govet --out-format=tab --deadline=60m --max-issues-per-linter=0 --max-same-issues=0 -j=2

I am recently comparing the results between golangci-lint(goll) and gometalinter(goml) since I am upgrading goml to goll shortly.
I found that results between the two runs are very different. For example:
Goml-golint outputs 2678 warnings while goll-golint only outpus 478. And 472 among goll-golint's warnings intersects with goml-golint's.
For some linters such as interfacer, errcheck and maligned, goll's result set does not even have any intersection with goml's.

(note: skipped dirs should not be the reason causing this issue, because some defective files which only appear in goml-unparam's result set appear in both goll-gochecknoinits's and goll-typecheck's)
(note: The number of warnings above does not include lll, gocyclo and dupl. I get rid of these three kinds of warning after I had the output)

[pierrre]

You're using --enable-all.
Do gometalinter and golangci-lint have the same linters ?
No.

[alexkohler]

I think iccen8's point is that running linters like errcheck through gometalinter and golangci give out different results. This said, @iccen8, could you please give a concrete example with code and the commands run?

[iccengan]

I think iccen8's point is that running linters like errcheck through gometalinter and golangci give out different results. This said, @iccen8, could you please give a concrete example with code and the commands run?

Yes, you have my point.

I have posted commands above:
Gometalinter command:
gometalinter ./... --enable-all --disable=govet --deadline=60m -j 2

Golangci-lint command:
golangci-lint run --enable-all --disable=govet --out-format=tab --deadline=60m --max-issues-per-linter=0 --max-same-issues=0 -j=2

Test code:
https://github.com/Tencent/bk-cmdb
(note: The downloaded source code should be placed into $GOPATH/src/configcenter)

The reason I disable govet is that govet is not running properly. Reference: #484

[alexaandru]

I just tested on my end and indeed, for errcheck I get no output from golangci-lint but I do get output when I run errcheck directly:

$ golangci-lint run --build-tags development --disable-all -E errcheck --no-config ./...|wc -l
0
$ errcheck -tags development ./...|wc -l
18

[iccengan]

I just tested on my end and indeed, for errcheck I get no output from golangci-lint but I do get output when I run errcheck directly:

$ golangci-lint run --build-tags development --disable-all -E errcheck --no-config ./...|wc -l
0
$ errcheck -tags development ./...|wc -l
18

Similar issue here #617

[pierrre]

Can you try --exclude-use-default false ?

[alexaandru]

Yes, I can see all the issues if I add --exclude-use-default=false ! Thank you! :)

[pierrre]

@alexaandru golangci-lint run --help and look at --exclude-use-default.

[iccengan]

I just tested on my end and indeed, for errcheck I get no output from golangci-lint but I do get output when I run errcheck directly:

$ golangci-lint run --build-tags development --disable-all -E errcheck --no-config ./...|wc -l
0
$ errcheck -tags development ./...|wc -l
18

Similar issue here #617

@alexkohler @pierrre
Just noticed the two issues are not quite similar. You are comparing golangci-lint vs errcheck, but I am comparing golangci-lint vs golangci-lint ;/

[Helcaraxan]

Aside from the hypothetical answer I provided to #617 you need to take into account that gometalinter and golangci-lint do not run the same versions of the underlying linters.

• gometalinter relies on the linter binaries being available (and you can thus determine the version of each linter), the gometalinter binary itself only contains the driver and error filtering logic.
• golangci-lint vendors the various linters at a specific commit (which is upgraded from time-to-time) and the golangci-lint binary effectively contains those linters (as well as the configuration and error filtering logic).

The result is that:

• Two people running the same version of gometalinter and the same config but with different versions of the underlying linters will likely get different error reports for the same code.
• The same two people running the same version of golangci-lint and the same config will always get the same error reports.

[jirfag]

1. Different linters
2. Different versions of linters
3. Different exclude rules

It doesn’t make sense to compare them