no default for n samples

mivanit · mivanit · commit 18b424da6ce3 · 2025-09-30T14:23:05.000+01:00
diff --git a/spd/clustering/pipeline/s2_clustering.py b/spd/clustering/pipeline/s2_clustering.py
@@ -139,6 +139,7 @@ def _run_clustering(
     plot_activations(
         processed_activations=processed_activations,
         save_dir=this_merge_plots_dir,
+        n_samples_max=256,  # TODO: make this configurable?
         wandb_run=run,
     )
     logger.info(f"plots saved to {this_merge_plots_dir}")
diff --git a/spd/clustering/plotting/activations.py b/spd/clustering/plotting/activations.py
@@ -18,8 +18,8 @@
 def plot_activations(
     processed_activations: ProcessedActivations,
     save_dir: Path,
+    n_samples_max: int,
     pdf_prefix: str = "activations",
-    n_samples_max: int = 256,
     figsize_raw: tuple[int, int] = (12, 4),
     figsize_concat: tuple[int, int] = (12, 2),
     figsize_coact: tuple[int, int] = (8, 6),
diff --git a/tests/clustering/scripts/cluster_resid_mlp.py b/tests/clustering/scripts/cluster_resid_mlp.py
@@ -106,6 +106,7 @@
 plot_activations(
     processed_activations=PROCESSED_ACTIVATIONS,
     save_dir=TEMP_DIR,
+    n_samples_max=256,
     wandb_run=None,
 )
 
diff --git a/tests/clustering/scripts/cluster_ss.py b/tests/clustering/scripts/cluster_ss.py
@@ -83,6 +83,7 @@
 plot_activations(
     processed_activations=PROCESSED_ACTIVATIONS,
     save_dir=TEMP_DIR,
+    n_samples_max=256,
     wandb_run=None,
 )
 

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,7 @@ def _run_clustering(`
`139`	`139`	`plot_activations(`
`140`	`140`	`processed_activations=processed_activations,`
`141`	`141`	`save_dir=this_merge_plots_dir,`
	`142`	`+ n_samples_max=256, # TODO: make this configurable?`
`142`	`143`	`wandb_run=run,`
`143`	`144`	`)`
`144`	`145`	`logger.info(f"plots saved to {this_merge_plots_dir}")`
Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,7 @@`
`106`	`106`	`plot_activations(`
`107`	`107`	`processed_activations=PROCESSED_ACTIVATIONS,`
`108`	`108`	`save_dir=TEMP_DIR,`
	`109`	`+ n_samples_max=256,`
`109`	`110`	`wandb_run=None,`
`110`	`111`	`)`
`111`	`112`
Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,7 @@`
`83`	`83`	`plot_activations(`
`84`	`84`	`processed_activations=PROCESSED_ACTIVATIONS,`
`85`	`85`	`save_dir=TEMP_DIR,`
	`86`	`+ n_samples_max=256,`
`86`	`87`	`wandb_run=None,`
`87`	`88`	`)`
`88`	`89`