Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for concept inventories to Model #57

Open
goodmami opened this issue Jan 29, 2020 · 2 comments
Open

Add support for concept inventories to Model #57

goodmami opened this issue Jan 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@goodmami
Copy link
Owner

goodmami commented Jan 29, 2020

This includes:

  • list/map of available concepts
  • Model.has_concept() (like Model.has_role())
  • Add checks to Model.errors()
  • (Maybe) consistency checks of roles, reifications, normalizations, and concepts
@goodmami goodmami added the enhancement New feature or request label Jan 29, 2020
@alvations
Copy link

alvations commented Jul 8, 2020

+1 for consistency checks, esp. when annotating text for AMR, it's very much free form =)

@goodmami
Copy link
Owner Author

goodmami commented Jul 8, 2020

@alvations yes, it is indeed very free, for better or worse. There are some things which can be checked easily, such as having a ARG3 on a concept that does not specify such an argument (these core arguments can't just appear anywhere, I don't think). Other roles, or concepts not in the inventory, are not really constrained. E.g., if we have a new concept wug, do we assume it can be a new verb that can take any number of core arguments? Can something like :op1 appear anywhere? Can :polarity take anything other than -, amr-unknown, truth-value? etc. For some of these things it might make sense to have a "goodness" score instead of a binary good/bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants